Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing manifest workflow #2879

Closed
wants to merge 2 commits into from
Closed

Fix failing manifest workflow #2879

wants to merge 2 commits into from

Conversation

rishabh6788
Copy link
Collaborator

Description

This PR fixes version workflow to auto update input manifests.

Issues Resolved

#2854

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabh6788
Copy link
Collaborator Author

Test TestInputManifestsOpenSearch.test_update is failing with below error:
AttributeError: 'Component' object has no attribute 'repository'.

I can see that the component class is different at runtime and testing.

Test: <class 'manifests.component_manifest.Component'>

Runtime: <class 'manifests.input_manifest.InputComponentFromSource'>

@prudhvigodithi @gaiksaya @zelinh @dblock Need your input on how to fix the test.
@bbarani

@dblock
Copy link
Member

dblock commented Nov 14, 2022

rishabh6788@2207262

@zelinh
Copy link
Member

zelinh commented Nov 15, 2022

Closed this as this is replaced by #2889

@zelinh zelinh closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants