Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JDK-19 builds on Jenkins #2808

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Support JDK-19 builds on Jenkins #2808

merged 4 commits into from
Nov 1, 2022

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 27, 2022

Signed-off-by: Andriy Redko [email protected]

Description

Support JDK-19 builds on Jenkins

Issues Resolved

Closes #2807

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner October 27, 2022 16:39
@reta reta mentioned this pull request Oct 27, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #2808 (9f68f6f) into main (71becf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         157      157           
  Lines        4242     4242           
=======================================
  Hits         3994     3994           
  Misses        248      248

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

peterzhuamazon
peterzhuamazon requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reta,

  1. Could you add corresponding JDK19 support PR from OpenSearch core?
  2. Do not make any changes to legacy ci image as they are not used anymore.
  3. Update JDK here: https://github.com/opensearch-project/opensearch-build/blob/main/docker/ci/config/jdk-setup.sh
  4. Block this until we add jdk19 tooling in Jenkins, I will append a PR later.

Thanks.

reta
reta commented Oct 27, 2022
View reviewed changes
docker/ci/config/jdk-setup.sh Outdated
@@ -23,12 +23,14 @@ case "${ARCH}" in
JDKS+="d10efb2afad3ed3d7bac9d3249cea77928aca6acb973cac0f90a2dd3606a3533@https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u332-b09/OpenJDK8U-jdk_aarch64_linux_hotspot_8u332b09.tar.gz "
JDKS+="999fbd90b070f9896142f0eb28354abbeb367cbe49fd86885c626e2999189e0a@https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.15%2B10/OpenJDK11U-jdk_aarch64_linux_hotspot_11.0.15_10.tar.gz "
JDKS+="2e3c19c1707205c6b90cc04b416e8d83078ed98417d5a69dce3cf7dc0d7cfbca@https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.3%2B7/OpenJDK17U-jdk_aarch64_linux_hotspot_17.0.3_7.tar.gz "
JDKS+="9b5de40b0f6fe0ab32e8d035720dbbc87bf41b758ed67351ad781ca6505f5294@https://github.com/adoptium/temurin19-binaries/releases/download/jdk-19%2B36/OpenJDK19U-jdk_aarch64_linux_hotspot_19_36.tar.gz "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19.0.1+10 for aarch64 is not yet published

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is ok, could you @ again once it is out.
We will then merge this PR.

Note this probably will take a while because all the related current runner that uses this jdk script would need to be updated.

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I am also adding 19.0.1+10 in Jenkins so let's wait a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is x64 or aarch64? x64 is fine btw

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhuamazon JDK 19.0.1+10 aarch64 bits released today, pull request updated

@peterzhuamazon peterzhuamazon mentioned this pull request Oct 27, 2022
Merged
@peterzhuamazon
Copy link
Member

@reta
Copy link
Contributor Author

reta commented Oct 28, 2022 •
edited
Loading 

1. Could you add corresponding JDK19 support PR from OpenSearch core?

So with that there are complications (not a blocker for CI support), in two words: right now we build each OpenSearch repo by extracting bundled_jdk version from the version properties. If we update bundled_jdk to use JDK-19, it will fail right away - we need CI support. What is worst though - Gradle 7.5.x does not support JDK-19 right now (7.6 will but it is in rc1), so we need to make an adjustment here to specify JDK for Gradle and JDK for build (basically, toolchain).

For that reasons, I will create a pull request for testing (if you need it) but I will keep it in draft state: opensearch-project/OpenSearch#4973

@peterzhuamazon
Copy link
Member

Thanks @reta we will hold this PR until all the docker images utilize jdk getting updated.
Thanks.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 1, 2022 •
edited
Loading

Planning update images:

peterzhuamazon
peterzhuamazon requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reta could you help verify above images?
Please do a hard pull and check if jdk19 is in action.

Thanks.

@reta
Copy link
Contributor Author

reta commented Nov 1, 2022

Hi @reta could you help verify above images? Please do a hard pull and check if jdk19 is in action.

Thanks.

@peterzhuamazon thanks a lot, confirming OpenJDK-19 is there (all images)

sh-4.2$ ls -Alc /opt/java/
rwxr-xr-x 9 root root 4096 Nov  1 23:07 openjdk-11
drwxr-xr-x 9 root root 4096 Nov  1 23:07 openjdk-17
drwxr-xr-x 9 root root 4096 Nov  1 23:07 openjdk-19
drwxr-xr-x 8 root root 4096 Nov  1 23:07 openjdk-8


sh-4.4$ /opt/java/openjdk-19/bin/java --version
openjdk 19.0.1 2022-10-18
OpenJDK Runtime Environment Temurin-19.0.1+10 (build 19.0.1+10)
OpenJDK 64-Bit Server VM Temurin-19.0.1+10 (build 19.0.1+10, mixed mode, sharing)

@peterzhuamazon peterzhuamazon merged commit 636dbdc into opensearch-project:main Nov 1, 2022
@peterzhuamazon peterzhuamazon added cicd jenkins Jenkins related issue labels Nov 1, 2022
@peterzhuamazon peterzhuamazon mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

Assignees
No one assigned
Labels
cicd jenkins Jenkins related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support JDK-19 builds on Jenkins
3 participants
@reta @codecov-commenter @peterzhuamazon