Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow docker build to use tags or commit checkout #2772

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Allow docker build to use tags or commit checkout

Issues Resolved

#2681

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added bug Something isn't working jenkins Jenkins related issue labels Oct 20, 2022
@peterzhuamazon peterzhuamazon self-assigned this Oct 20, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner October 20, 2022 23:06
@codecov-commenter
Copy link

Codecov Report

Merging #2772 (492f1fb) into main (b85f95e) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   94.15%   93.82%   -0.34%     
==========================================
  Files         157      157              
  Lines        4242     4242              
==========================================
- Hits         3994     3980      -14     
- Misses        248      262      +14     
Impacted Files Coverage Δ
src/system/temporary_directory.py 64.44% <0.00%> (-28.89%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit d277073 into opensearch-project:main Oct 20, 2022
@peterzhuamazon peterzhuamazon deleted the docker-build-accept-tags-commits branch October 20, 2022 23:29
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jenkins Jenkins related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants