Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows specific plugin installation for dashboards #2730

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Add windows specific plugin installation for dashboards

Issues Resolved

#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #2730 (c50fad5) into main (7a4f4dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2730   +/-   ##
=======================================
  Coverage   94.10%   94.11%           
=======================================
  Files         156      156           
  Lines        4208     4212    +4     
=======================================
+ Hits         3960     3964    +4     
  Misses        248      248           
Impacted Files Coverage Δ
.../assemble_workflow/bundle_opensearch_dashboards.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with fixed CI.

@prudhvigodithi
Copy link
Member

The test failed for Task :jacocoTestReport FAILED, this is a know error CC @gaiksaya @jordarlu.

@peterzhuamazon peterzhuamazon force-pushed the opensearch-windows-bundle-9 branch 3 times, most recently from a0eccf7 to c50fad5 Compare October 14, 2022 22:05
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member Author

The groovy test is not related, merging now.

@peterzhuamazon peterzhuamazon merged commit b14b8bb into opensearch-project:main Oct 17, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-windows-bundle-9 branch October 17, 2022 17:19
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
…roject#2730)

* Add windows specific plugin installation for dashboards

Signed-off-by: Peter Zhu <[email protected]>

* Add tests

Signed-off-by: Peter Zhu <[email protected]>

* Remove .swp

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants