-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resume Windows Build and Add Platform Specific Build Params #2678
Merged
peterzhuamazon
merged 25 commits into
opensearch-project:main
from
peterzhuamazon:opensearch-windows-bundle-6
Oct 5, 2022
Merged
Resume Windows Build and Add Platform Specific Build Params #2678
peterzhuamazon
merged 25 commits into
opensearch-project:main
from
peterzhuamazon:opensearch-windows-bundle-6
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
…roject#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <[email protected]> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
* Add security plugin into the manifest Signed-off-by: Zelin Hao <[email protected]> * Add more components Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2678 +/- ##
==========================================
- Coverage 94.10% 93.77% -0.34%
==========================================
Files 156 156
Lines 4208 4208
==========================================
- Hits 3960 3946 -14
- Misses 248 262 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
…bundle-6 Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
1 task
Signed-off-by: Peter Zhu <[email protected]>
zelinh
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
monusingh-1
pushed a commit
to monusingh-1/os_build
that referenced
this pull request
Nov 2, 2022
…ch-project#2678) * Test windows Signed-off-by: Peter Zhu <[email protected]> * Test windows Signed-off-by: Peter Zhu <[email protected]> * Test snapshots Signed-off-by: Peter Zhu <[email protected]> * Add new manifests Signed-off-by: Peter Zhu <[email protected]> * Test again Signed-off-by: Peter Zhu <[email protected]> * Fix zip distribution does not include leading directory (opensearch-project#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <[email protected]> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> * Tweak 1.3.6 Signed-off-by: Peter Zhu <[email protected]> * Add some plugins to the 1.3.6 manifest (opensearch-project#2670) * Add security plugin into the manifest Signed-off-by: Zelin Hao <[email protected]> * Add more components Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Zelin Hao <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Change when condition Signed-off-by: Peter Zhu <[email protected]> * change params Signed-off-by: Peter Zhu <[email protected]> * Add verify params Signed-off-by: Peter Zhu <[email protected]> * Add verify params Signed-off-by: Peter Zhu <[email protected]> * Remove .swp Signed-off-by: Peter Zhu <[email protected]> * Add more comment Signed-off-by: Peter Zhu <[email protected]> * Fix issues Signed-off-by: Peter Zhu <[email protected]> * More changes Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Signed-off-by: Monu Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resume Windows Build and Add Platform Specific Build Params
Issues Resolved
#2306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.