Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume Windows Build and Add Platform Specific Build Params #2678

Conversation

peterzhuamazon
Copy link
Member

Description

Resume Windows Build and Add Platform Specific Build Params

Issues Resolved

#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon and others added 13 commits September 27, 2022 14:31
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
…roject#2672)

* Fix zip distribution does not include leading directory

Signed-off-by: Peter Zhu <[email protected]>

* Resolve the path issues failed on Windows

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
* Add security plugin into the manifest

Signed-off-by: Zelin Hao <[email protected]>

* Add more components

Signed-off-by: Zelin Hao <[email protected]>

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon self-assigned this Sep 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #2678 (380dffb) into main (077fc28) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2678      +/-   ##
==========================================
- Coverage   94.10%   93.77%   -0.34%     
==========================================
  Files         156      156              
  Lines        4208     4208              
==========================================
- Hits         3960     3946      -14     
- Misses        248      262      +14     
Impacted Files Coverage Δ
src/system/temporary_directory.py 64.44% <0.00%> (-28.89%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon marked this pull request as ready for review October 4, 2022 22:57
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner October 4, 2022 22:57
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@peterzhuamazon peterzhuamazon merged commit c527ce7 into opensearch-project:main Oct 5, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-windows-bundle-6 branch October 5, 2022 18:59
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
…ch-project#2678)

* Test windows

Signed-off-by: Peter Zhu <[email protected]>

* Test windows

Signed-off-by: Peter Zhu <[email protected]>

* Test snapshots

Signed-off-by: Peter Zhu <[email protected]>

* Add new manifests

Signed-off-by: Peter Zhu <[email protected]>

* Test again

Signed-off-by: Peter Zhu <[email protected]>

* Fix zip distribution does not include leading directory (opensearch-project#2672)

* Fix zip distribution does not include leading directory

Signed-off-by: Peter Zhu <[email protected]>

* Resolve the path issues failed on Windows

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>

* Tweak 1.3.6

Signed-off-by: Peter Zhu <[email protected]>

* Add some plugins to the 1.3.6 manifest (opensearch-project#2670)

* Add security plugin into the manifest

Signed-off-by: Zelin Hao <[email protected]>

* Add more components

Signed-off-by: Zelin Hao <[email protected]>

Signed-off-by: Zelin Hao <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

* Change when condition

Signed-off-by: Peter Zhu <[email protected]>

* change params

Signed-off-by: Peter Zhu <[email protected]>

* Add verify params

Signed-off-by: Peter Zhu <[email protected]>

* Add verify params

Signed-off-by: Peter Zhu <[email protected]>

* Remove .swp

Signed-off-by: Peter Zhu <[email protected]>

* Add more comment

Signed-off-by: Peter Zhu <[email protected]>

* Fix issues

Signed-off-by: Peter Zhu <[email protected]>

* More changes

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants