Update uploadIndexFile lib env vars with credentials #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
commented
Jun 23, 2022
| @@ -2,11 +2,13 @@ void call(Map args = [:]) { | |||
| def latestBuildData = ['latest': "${BUILD_NUMBER}"] | |||
| writeJSON file: 'index.json', json: latestBuildData | |||
|
|
|||
| echo "Uploading index.json to s3://${ARTIFACT_PRODUCTION_BUCKET_NAME}/${args.indexFilePath}" | |||
| withCredentials([string(credentialsId: 'jenkins-artifact-bucket-name', variable: 'ARTIFACT_BUCKET_NAME')]) { | |||
| echo "Uploading index.json to s3://${ARTIFACT_BUCKET_NAME}/${args.indexFilePath}" | |||
There was a problem hiding this comment.
Hi @tianleh can you review this. It looked like a bug in echo statement before so I changed it.
Thanks!
tianleh
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayali Gaikawad [email protected]
Description
Update uploadIndexFile lib env vars with credentials
Confirming that the credentials used are already present in current jenkins env
Issues Resolved
Part of #2220
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.