Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce input manifest build frequency for new upcoming versions #2231

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jun 22, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Reduce input manifest build frequency for new upcoming versions.
Every time when a new input manifest getting created, it often doesnt have all the necessary pieces.
Core not ready, plugin not bumping or supporting it, etc.
It is not very useful to build every 10min for these broken builds.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added cicd jenkins Jenkins related issue labels Jun 22, 2022
@peterzhuamazon peterzhuamazon requested a review from gaiksaya June 22, 2022 23:15
@peterzhuamazon peterzhuamazon self-assigned this Jun 22, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner June 22, 2022 23:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #2231 (0abf203) into main (5ffbbb9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2231   +/-   ##
=========================================
  Coverage     94.56%   94.56%           
  Complexity       25       25           
=========================================
  Files           205      205           
  Lines          4254     4254           
  Branches         29       29           
=========================================
  Hits           4023     4023           
  Misses          225      225           
  Partials          6        6           
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py 98.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffbbb9...0abf203. Read the comment docs.

@peterzhuamazon peterzhuamazon requested a review from zelinh June 22, 2022 23:16
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also need to add step in release template to increase the frequency when release is close by

@peterzhuamazon
Copy link
Member Author

Maybe also need to add step in release template to increase the frequency when release is close by

We still need to think about how to approach this cause machines does not know when we want to release 😄

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 570a8ce into opensearch-project:main Jun 22, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-reduce-builds branch June 22, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd jenkins Jenkins related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants