Add uninstall function for tar integTest between plugins #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
51 tasks
zelinh
approved these changes
Apr 21, 2022
dblock
reviewed
Apr 22, 2022
| def uninstall(self) -> None: | ||
| """ | ||
| Allow distribution that is not 'tar' to do proper cleanup | ||
| Allow distribution to do proper cleanup |
There was a problem hiding this comment.
To cleanup. Proper is unnecessary filler.
There was a problem hiding this comment.
Will change later.
|
|
||
| def uninstall(self) -> None: | ||
| logging.info(f"Cleanup {self.work_dir}/* content after the test") | ||
| subprocess.check_call(f"rm -rf {self.work_dir}/*", shell=True) |
There was a problem hiding this comment.
It always worries me to have “rm -rf”, and it won’t work for windows, is there a python method?
There was a problem hiding this comment.
There is ways to cleanup a folder, but not contents within the folder, unless you list all the files and loop deletion.
Will try researching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Add uninstall function for tar integTest between plugins.
Now the cluster is green not yellow between each plugin type run.
Issues Resolved
#2018
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.