Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag docker image as latest in docker promote job #2001

Conversation

abhinavGupta16
Copy link
Contributor

Signed-off-by: Abhinav Gupta [email protected]

Description

option to tag image as latest in docker promote job

Issues Resolved

#1935

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Abhinav Gupta <[email protected]>
@abhinavGupta16 abhinavGupta16 requested a review from a team as a code owner April 20, 2022 01:10
@abhinavGupta16 abhinavGupta16 self-assigned this Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2001 (da02b77) into main (ec1e4dd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2001   +/-   ##
=========================================
  Coverage     94.41%   94.41%           
  Complexity       22       22           
=========================================
  Files           187      187           
  Lines          3739     3739           
  Branches         29       29           
=========================================
  Hits           3530     3530           
  Misses          203      203           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1e4dd...da02b77. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good just need a co-review from @zelinh

@peterzhuamazon peterzhuamazon merged commit 6c8817b into opensearch-project:main Apr 20, 2022
@peterzhuamazon peterzhuamazon deleted the abhng-tag-latest-docker-promote branch April 20, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants