Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpm support in integTest framework (2nd PR) #2000

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Add rpm support in integTest framework (2nd PR)

Issues Resolved

#1951

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member Author

Hi @dblock please review as I will add test cases soon.

Thanks.

@peterzhuamazon peterzhuamazon linked an issue Apr 19, 2022 that may be closed by this pull request
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2000 (3e17ea3) into main (7c732e9) will decrease coverage by 0.06%.
The diff coverage is 93.91%.

@@             Coverage Diff              @@
##               main    #2000      +/-   ##
============================================
- Coverage     94.41%   94.34%   -0.07%     
  Complexity       22       22              
============================================
  Files           187      191       +4     
  Lines          3739     3821      +82     
  Branches         29       29              
============================================
+ Hits           3530     3605      +75     
- Misses          203      210       +7     
  Partials          6        6              
Impacted Files Coverage Δ
src/test_workflow/integ_test/local_test_cluster.py 100.00% <ø> (ø)
...g_test/local_test_cluster_opensearch_dashboards.py 100.00% <ø> (ø)
src/test_workflow/integ_test/distribution.py 80.00% <80.00%> (ø)
...rkflow/integ_test/service_opensearch_dashboards.py 96.00% <90.00%> (-2.22%) ⬇️
src/test_workflow/integ_test/distributions.py 94.11% <94.11%> (ø)
src/test_workflow/integ_test/distribution_rpm.py 100.00% <100.00%> (ø)
src/test_workflow/integ_test/distribution_tar.py 100.00% <100.00%> (ø)
src/test_workflow/integ_test/service.py 93.05% <100.00%> (+0.86%) ⬆️
src/test_workflow/integ_test/service_opensearch.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c732e9...3e17ea3. Read the comment docs.

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot better, but go further in subclassing or generalize the distribution start/stop code. Basically get rid of those maps of product -> commands.

src/test_workflow/integ_test/distribution.py Outdated Show resolved Hide resolved
src/test_workflow/integ_test/distribution.py Outdated Show resolved Hide resolved
src/test_workflow/integ_test/distribution.py Show resolved Hide resolved
src/test_workflow/integ_test/distribution.py Outdated Show resolved Hide resolved
src/test_workflow/integ_test/distribution_rpm.py Outdated Show resolved Hide resolved
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member Author

@dblock @tianleh @zelinh please review again.

Thanks.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@peterzhuamazon peterzhuamazon merged commit 74b532b into opensearch-project:main Apr 20, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-integtest-passing2 branch April 20, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate integ test using RPM bundle.
3 participants