-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rpm support in integTest framework (2nd PR) #2000
Add rpm support in integTest framework (2nd PR) #2000
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Hi @dblock please review as I will add test cases soon. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2000 +/- ##
============================================
- Coverage 94.41% 94.34% -0.07%
Complexity 22 22
============================================
Files 187 191 +4
Lines 3739 3821 +82
Branches 29 29
============================================
+ Hits 3530 3605 +75
- Misses 203 210 +7
Partials 6 6
Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot better, but go further in subclassing or generalize the distribution start/stop code. Basically get rid of those maps of product -> commands.
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Signed-off-by: Peter Zhu [email protected]
Description
Add rpm support in integTest framework (2nd PR)
Issues Resolved
#1951
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.