-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CopyContainer documentation #1609
Conversation
Add additional documentation for the copyContainer function to make it clear what source/destinations can be used. Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1609 +/- ##
=========================================
Coverage 94.66% 94.66%
Complexity 13 13
=========================================
Files 162 162
Lines 3433 3433
Branches 21 21
=========================================
Hits 3250 3250
Misses 180 180
Partials 3 3
Continue to review full report at Codecov.
|
@dlvenable FYI |
@peternied , Thanks for tagging me and for improving the documentation. This will be helpful for Data Prepper. I'm curious why renamed it to |
@dlvenable The rename was to remove the docker centric nature of the previous name, so that callers would not look for a |
Add additional documentation for the copyContainer function to make it clear what source/destinations can be used. Signed-off-by: Peter Nied <[email protected]>
Description
Renamed the function from copyDockerImage to copyContainer that more appropriate fits the functionality
Add additional documentation for the copyContainer function to make it clear what source/destinations can be used.
Following up a comment that was made on the proof of concept about the limitations of container copying
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.