Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyContainer documentation #1609

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

peternied
Copy link
Member

@peternied peternied commented Feb 9, 2022

Description

Renamed the function from copyDockerImage to copyContainer that more appropriate fits the functionality
Add additional documentation for the copyContainer function to make it clear what source/destinations can be used.

Following up a comment that was made on the proof of concept about the limitations of container copying

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add additional documentation for the copyContainer function to make it
clear what source/destinations can be used.

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied added the documentation Improvements or additions to documentation label Feb 9, 2022
@peternied peternied requested a review from a team as a code owner February 9, 2022 21:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #1609 (e52f089) into main (0a20ec1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1609   +/-   ##
=========================================
  Coverage     94.66%   94.66%           
  Complexity       13       13           
=========================================
  Files           162      162           
  Lines          3433     3433           
  Branches         21       21           
=========================================
  Hits           3250     3250           
  Misses          180      180           
  Partials          3        3           
Impacted Files Coverage Δ
...ests/jenkins/jobs/CopyContainer_docker_Jenkinsfile 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a20ec1...e52f089. Read the comment docs.

@dblock dblock requested review from peterzhuamazon and a team February 9, 2022 22:09
@peternied
Copy link
Member Author

@dlvenable FYI

@peternied peternied merged commit 18f6e51 into opensearch-project:main Feb 9, 2022
@peternied peternied deleted the copy-container branch February 9, 2022 22:13
@dlvenable
Copy link
Member

@peternied , Thanks for tagging me and for improving the documentation. This will be helpful for Data Prepper.

I'm curious why renamed it to copyContainer. It is copying images, not containers, right?

@peternied
Copy link
Member Author

@dlvenable The rename was to remove the docker centric nature of the previous name, so that callers would not look for a copyECRImage(...) function. copyContainerImage would be correct and I did not think of it when I picked the name. I think this will work.

peterzhuamazon pushed a commit to peterzhuamazon/opensearch-build that referenced this pull request Feb 16, 2022
Add additional documentation for the copyContainer function to make it clear what source/destinations can be used.

Signed-off-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants