Rename internal filename of sha512 so checksum pass #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
assigned abhinavGupta16, zelinh and kavilla and unassigned abhinavGupta16 and zelinh
peterzhuamazon
assigned peterzhuamazon and unassigned kavilla, abhinavGupta16 and zelinh
Signed-off-by: Peter Zhu <[email protected]>
gaiksaya
reviewed
Feb 1, 2022
Signed-off-by: Peter Zhu <[email protected]>
kavilla
approved these changes
Feb 1, 2022
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1581 +/- ##
=========================================
Coverage 94.46% 94.46%
Complexity 12 12
=========================================
Files 153 153
Lines 3233 3233
Branches 23 23
=========================================
Hits 3054 3054
Misses 172 172
Partials 7 7 Continue to review full report at Codecov.
|
|
@gaiksaya @peternied please take a look for the changes with id removed. Thanks. |
gaiksaya
reviewed
Feb 1, 2022
abhinavGupta16
suggested changes
Feb 1, 2022
Signed-off-by: Peter Zhu <[email protected]>
|
If we did a 302 redirect from |
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Feb 16, 2022
…ect#1581) * Adding checksum for latest snapshots artifacts Signed-off-by: Peter Zhu <[email protected]> * Change to snapshots dir name in path Signed-off-by: Peter Zhu <[email protected]> * Update test stack with new location Signed-off-by: Peter Zhu <[email protected]> * Simplify the naming in artifacts variables Signed-off-by: Peter Zhu <[email protected]> * Rename internal filename of sha512 so checksum pass Signed-off-by: Peter Zhu <[email protected]> * Update tests Signed-off-by: Peter Zhu <[email protected]> * Remove id number Signed-off-by: Peter Zhu <[email protected]> * Move sh block outside of withAWS block Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename internal filename of sha512 so checksum pass:
In #1574 we simply rename the checksum file without replacing the internal filename to the new one.
This PR we fix this issue by using sed to replace the names.
Issues Resolved
#1497
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.