Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dashboards 1.3.0 version since 2.0.0 will be the next version #1470

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

peternied
Copy link
Member

Signed-off-by: Peter Nied [email protected]

Description

Dashboards is moving node versions opensearch-project/OpenSearch-Dashboards#920, the 1.3.0 release will not be used

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team as a code owner January 13, 2022 22:52
@peternied peternied added the bug Something isn't working label Jan 13, 2022
@gaiksaya gaiksaya requested review from kavilla and tianleh January 13, 2022 23:07
@dblock dblock merged commit c177c5a into opensearch-project:main Jan 13, 2022
@kavilla
Copy link
Member

kavilla commented Jan 13, 2022

We have an issue: opensearch-project/OpenSearch-Dashboards#1099, to track if it is possible that we can release OpenSearch Dashboards 2.0.0 targeting the OpenSearch 1.3.0 release. Even after verifying, I believe we still want to make sure to propose to the community that we plan to split the version of OpenSearch and OpenSearch Dashboards. Historically and programmatically (like there are checks to make sure that OpenSearch Dashboards version major.minor matched OpenSearch major.minor before starting up), they have gone hand and hand with major and minor versions.

So I know it has been merged but I reckon if there is push back or if a plugin breaks compatibility on major versions then we should reconsider adding this back.

@dblock
Copy link
Member

dblock commented Jan 13, 2022

We have an issue: opensearch-project/OpenSearch-Dashboards#1099, to track if it is possible that we can release OpenSearch Dashboards 2.0.0 targeting the OpenSearch 1.3.0 release. Even after verifying, I believe we still want to make sure to propose to the community that we plan to split the version of OpenSearch and OpenSearch Dashboards. Historically and programmatically (like there are checks to make sure that OpenSearch Dashboards version major.minor matched OpenSearch major.minor before starting up), they have gone hand and hand with major and minor versions.

So I know it has been merged but I reckon if there is push back or if a plugin breaks compatibility on major versions then we should reconsider adding this back.

That's cool. We can always re-create manifests as needed.

@peternied peternied deleted the remove-dashboards-1.3.0 branch January 13, 2022 23:22
peterzhuamazon pushed a commit to peterzhuamazon/opensearch-build that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants