Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting PR 1232 #1245

Merged

Conversation

abhinavGupta16
Copy link
Contributor

@abhinavGupta16 abhinavGupta16 commented Dec 3, 2021

Signed-off-by: Abhinav Gupta [email protected]

Description

Reverting PR #1232 due to build fail

Issues Resolved

Reverting PR #1232 due to build fail

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Abhinav Gupta <[email protected]>
@abhinavGupta16 abhinavGupta16 requested a review from a team as a code owner December 3, 2021 22:29
@peternied peternied merged commit ea6a5e0 into opensearch-project:main Dec 3, 2021
@gaiksaya
Copy link
Member

gaiksaya commented Dec 3, 2021

@peternied alerting will fail because of https://github.com/opensearch-project/alerting/blob/main/build.gradle#L34
Need to remove that as well from manifest?

@peternied
Copy link
Member

@gaiksaya Separate PR to include that change back #1246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants