Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run OpenSearch Dashboards build in Jenkins #620

Closed
Tracked by #573
dblock opened this issue Sep 27, 2021 · 0 comments · Fixed by #717
Closed
Tracked by #573

Run OpenSearch Dashboards build in Jenkins #620

dblock opened this issue Sep 27, 2021 · 0 comments · Fixed by #717
Assignees
Labels
enhancement New Enhancement opensearch-dashboards v1.2.0 OpenSearch 1.2 version

Comments

@dblock
Copy link
Member

dblock commented Sep 27, 2021

Is your feature request related to a problem? Please describe

Coming from #158, add the manifest to Jenkins and publish artifacts.

Describe the solution you'd like

I want to see 1.1.0 dashboards in Jenkins and dropping the bundle.

Subtasks

@kavilla kavilla added the v1.2.0 OpenSearch 1.2 version label Oct 6, 2021
kavilla added a commit to kavilla/opensearch-build that referenced this issue Oct 8, 2021
Re-using the existing Jenkinsfile for OpenSearch and adds OpenSearch
Dashboards to the build. This means the same pipeline will build both
OpenSearch and OpenSearch Dashboards.

A few caveats, this skips publishing to maven if manifest build name
is not OpenSearch. Also, will publish to S3 builds/artifacts for
OpenSearch but builds/dashboards/artifacts for OpenSearch Dashboards.
This is unverified if this is possible to do but to avoid modifying the
testing scripts to pull from the right location. If this possible to
go this route then this can be iterated upon to publish to a path
for OpenSearch and OpenSearch Dashboards and having the tests pull
from the right path in S3.

Issue resolved:
opensearch-project#620

Blocked by:
opensearch-project/OpenSearch-Dashboards#850

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/opensearch-build that referenced this issue Oct 11, 2021
Creates OpenSearch Dashboards Jenkinsfile basically copying what was
in the existing OpenSearch Jenkinsfile. But skipping snapshots since
it was not doing anything with snapshots and publishing to S3
bucket paths of `/builds/dashboards/` and `/bundles/dashboards/` which
has not been verified yet. It was done this way, while keeping OpenSearch
to build to `/builds` and `/bundles`, to reduce the impact of adding
OpenSearch Dashboards.

For consistency, moved the root lvl Jenkinsfile which was only  building
OpenSearch to `jenkins/opensearch`.

Issue resolved:
opensearch-project#620

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla linked a pull request Oct 11, 2021 that will close this issue
1 task
dblock pushed a commit that referenced this issue Oct 12, 2021
* [Build] create Dashboards Jenkinsfile and move OpenSearch Jenkinsfile

Creates OpenSearch Dashboards Jenkinsfile basically copying what was
in the existing OpenSearch Jenkinsfile. But skipping snapshots since
it was not doing anything with snapshots and publishing to S3
bucket paths of `/builds/dashboards/` and `/bundles/dashboards/` which
has not been verified yet. It was done this way, while keeping OpenSearch
to build to `/builds` and `/bundles`, to reduce the impact of adding
OpenSearch Dashboards.

For consistency, moved the root lvl Jenkinsfile which was only  building
OpenSearch to `jenkins/opensearch`.

Issue resolved:
#620

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] remove Java arg, x86 to x64, s3 bucket rename

Handling the feedback without any question:

* Remove JAVA arg since it is unneeded for OpenSearch Dashboards.
* Change from x86 to x64
* Change S3 bucket from dashboards to opensearch-dashboards

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] rename folder and update build id for dashboards

Update from feedback with potential to require more discussion.
* Rename folder from jenkins/opensearch_dashboards to jenkins/opensearch-dashboards
* Build ID from OPENSEARCH_BUILD_ID to OPENSEARCH_DASHBOARDS_BUILD_ID

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement opensearch-dashboards v1.2.0 OpenSearch 1.2 version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants