Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OpenSearch Dashboards release functional tests into CI process #604

Closed
36 tasks done
tianleh opened this issue Sep 24, 2021 · 19 comments
Closed
36 tasks done

Comments

@tianleh
Copy link
Member

tianleh commented Sep 24, 2021

Is your feature request related to a problem? Please describe

We want to integrate OSD release test https://github.com/opensearch-project/opensearch-dashboards-functional-test into the infra CI. We have already verified that it can run in Github Action env.

(See this sample run https://github.com/opensearch-project/opensearch-dashboards-functional-test/runs/3705023275?check_suite_focus=true)

Describe the solution you'd like

The overall process would be:

For security enabled cluster,

checkout opensearch-dashboards-functional-test from Github
run npx cypress run --spec "cypress/integration/security-enabled/*.js"

For security disabled cluster,

checkout opensearch-dashboards-functional-test from Github
run npx cypress run --spec "cypress/integration/security-disabled/*.js"

(One call out is that opensearch-dashboards-functional-test imports another library repo https://github.com/opensearch-project/opensearch-dashboards-test-library through NPM registry.)

Describe alternatives you've considered

We could just use the Github Actions https://github.com/opensearch-project/opensearch-dashboards-functional-test However, it is isolated outside of the org workflow.

Task breakdown

Fast Followups

@tianleh tianleh added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Sep 24, 2021
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 24, 2021

Since test-workflow haven't officially support dashboards/cypress yet, we will try to run this on the old Jenkins Workflow next week with repository integtest.sh.
We will migrate it to test-workflow once it is ready.

Thanks.

@peterzhuamazon peterzhuamazon self-assigned this Sep 24, 2021
@seraphjiang
Copy link
Member

what's the gap to run cypress? is there an open issue to track, want to know more

@peterzhuamazon
Copy link
Member

We have successfully test the changes on Jenkins with both Security and No-Security tests on x64 docker container.
Due to arm64 cypress not having available binary, we have not test on arm64 yet.

@peternied peternied removed the untriaged Issues that have not yet been triaged label Sep 28, 2021
@dblock dblock changed the title Integrate OSD release functional tests into CI process Integrate OpenSearch Dashboards release functional tests into CI process Oct 5, 2021
@seraphjiang
Copy link
Member

Is there an issue to track we need two parameters need to run test?

@tianleh
Copy link
Member Author

tianleh commented Oct 19, 2021

Is there an issue to track we need two parameters need to run test?

Created a Github issue for the tight coupling of build and bundle in current integ test.

#761

@tianleh
Copy link
Member Author

tianleh commented Oct 19, 2021

My ongoing POC work is pushed to this dev branch https://github.com/tianleh/opensearch-build/tree/add-test-support

Still in progress to address build and bundle related params

@peterzhuamazon
Copy link
Member

Since @tianleh has mentioned in chat before, you need to set these up in your docker host to ensure cypress wont crash:

https://github.com/opensearch-project/opensearch-build/blob/main/scripts/README.md#requirements

@peternied
Copy link
Member

[Triage] @tianleh Could you add individual tasks that would align to the PRs that you are creating where this task is broken into more digestible pieces?

@peternied
Copy link
Member

[Triage] @peterzhuamazon is tracking this item, and the costing reflects this. If it makes sense to break this apart into more than one item please do what works best for you.

@tianleh
Copy link
Member Author

tianleh commented Nov 9, 2021

Refer to the description section of this issue (top)

@tianleh
Copy link
Member Author

tianleh commented Nov 9, 2021

My POC work https://github.com/tianleh/opensearch-build/tree/add-test-support is working. Focusing on moving the POC code to official repo

@tianleh
Copy link
Member Author

tianleh commented Nov 29, 2021

To track PR/Issue related to release integ test, I created a new label ci-test-automation

To track those PRs which have been approved/merged with comments, I created a new label comment-to-followup
(Once remaining comments are resolved in follow up PRs, I will remove the label)

@tianleh
Copy link
Member Author

tianleh commented Mar 10, 2022

Added a few items to track our work with infra team about upgrading to Chromium to

  1. stabilize the test
  2. support Reporting plugin

@bbarani
Copy link
Member

bbarani commented Oct 18, 2022

@tianleh Whats the status of this issue?

@bbarani
Copy link
Member

bbarani commented Jan 30, 2023

@tianleh @peterzhuamazon @kavilla Can you please update the current status of this issue?

@gaiksaya
Copy link
Member

Closing this issue as we are now using opensearch-functional-test repo to run tests for all dashboards plugin. No action items pending from infra side.

Please re-open if you think any items are pending.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants