-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the structure for release url and regular distribution url for running Dashboards integ test #1482
Comments
This makes sense. I think we inherited |
Digging the repo and didn't find where the logic is about the release endpoint. By searching "artifacts.opensearch.org", only find this signing logic https://github.com/opensearch-project/opensearch-build/blob/main/vars/signArtifacts.groovy#L34 Could anyone help point to where the logic is or any documents about it? @dblock @peternied @peterzhuamazon |
The artifacts are moved from staging to production using the below code base https://github.com/opensearch-project/opensearch-build/blob/main/vars/promoteArtifacts.groovy#L71-L83 |
Tuning on the code change in promoteArtifacts.groovy to make the path hierarchy consistent |
Is your feature request related to a problem? Please describe
Background: to run Dashboards integ test against public endpoint, this is the command
Note that for integ test, we are reading the artifact URL from the bundle manifest (attribute
location
) instead of taking it from input directly.(https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/dependency_installer.py#L28)
For the url for
opensearch
, we expect the following sub pathsbuilds/opensearch/manifest.yml
for build manifestdist/opensearch/manifest.yml
for bundle manifest(Link to code https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/integ_test_start_properties_opensearch.py#L13)
For the url for
opensearch-dashboards
, we expectbuilds/opensearch-dashboards/manifest.yml
for build manifestdist/opensearch-dashboards/manifest.yml
for bundle manifest(Link to code https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/integ_test_start_properties_opensearch_dashboards.py#L13)
This is the link to release artifact https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/1.2.0/opensearch-dashboards-1.2.0-linux-x64.tar.gz
To run integ test against this release url, we need
https://artifacts.opensearch.org/releases
to have a similar structure above.Describe the solution you'd like
Given the base release URL https://artifacts.opensearch.org/releases/1.2.0, I want to have
https://artifacts.opensearch.org/releases/1.2.0/builds/opensearch/manifest.yml
https://artifacts.opensearch.org/releases/1.2.0/dist/opensearch/manifest.yml
https://artifacts.opensearch.org/releases/1.2.0/builds/opensearch-dashboards/manifest.yml
https://artifacts.opensearch.org/releases/1.2.0/dist/opensearch-dashboards/manifest.yml
In terms of the current release URL https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/1.2.0/opensearch-dashboards-1.2.0-linux-x64.tar.gz
It can be replaced by https://artifacts.opensearch.org/releases/1.2.0/dist/opensearch-dashboards/opensearch-dashboards-1.2.0-linux-x64.tar.gz
(or we can also keep the old one to minimize the impact)
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: