Use HOME var instead of tilde to be more comparible with Windows #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
requested review from
prudhvigodithi,
gaiksaya,
rishabh6788,
Divyaasm and
zelinh
as code owners
peterzhuamazon
changed the title
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
changed the title
peterzhuamazon
force-pushed
the
use-home-var
branch
from
faddc02 to
9814c7d
Compare
Signed-off-by: Peter Zhu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 105 105
=========================================
Files 115 115
Lines 648 648
Branches 71 71
=========================================
Hits 549 549
Misses 29 29
Partials 70 70 ☔ View full report in Codecov by Sentry. |
rishabh6788
approved these changes
Oct 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit b7e7b62) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use HOME var instead of tilde to be more comparible with Windows
Issues Resolved
opensearch-project/opensearch-build#5004
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.