Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instance based storge in nightly benchmark run #522

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

rishabh6788
Copy link
Collaborator

Description

We recently added support to use instance based SSD storage in opensearch-project/opensearch-cluster-cdk#134.
We need to enable the same feature in nightly benchmark workflow.

opensearch-project/opensearch-build#5079

Issues Resolved

opensearch-project/opensearch-build#5066

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (39113a6) to head (5e1c5bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #522   +/-   ##
=========================================
  Coverage     84.72%   84.72%           
  Complexity      105      105           
=========================================
  Files           115      115           
  Lines           648      648           
  Branches         71       71           
=========================================
  Hits            549      549           
  Misses           29       29           
  Partials         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishabh6788 rishabh6788 merged commit a84c88e into opensearch-project:main Oct 8, 2024
9 checks passed
@opensearch-trigger-bot
Copy link

The backport to 6.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-6.x 6.x
# Navigate to the new working tree
pushd ../.worktrees/backport-6.x
# Create a new branch
git switch --create backport/backport-522-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a84c88e626d7c48c5041b39019085de9c0e8f9ab
# Push it to GitHub
git push --set-upstream origin backport/backport-522-to-6.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-6.x

Then, create a pull request where the base branch is 6.x and the compare/head branch is backport/backport-522-to-6.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 8, 2024
Signed-off-by: Rishabh Singh <[email protected]>
(cherry picked from commit a84c88e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rishabh6788 pushed a commit that referenced this pull request Oct 8, 2024
Signed-off-by: Rishabh Singh <[email protected]>
(cherry picked from commit a84c88e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants