-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compare logic to opensearch build libraries #478
add compare logic to opensearch build libraries #478
Conversation
Signed-off-by: Michael Oviedo <[email protected]>
445c1a3
to
c016e49
Compare
vars/runBenchmarkTestScript.groovy
Outdated
@@ -71,44 +78,60 @@ void call(Map args = [:]) { | |||
editBenchmarkConfig("${WORKSPACE}/benchmark.ini") | |||
String userTags = getMetadataTags(args.userTag.toString(), buildManifest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this inside the execute-test
if logic. And the above if-else logic as well.
if (args.insecure.toBoolean()) {
sleep(5)
} else {
sleep(120)
}
These are not required for compare
, args.insecure.toBoolean()
will result in error if not passed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
============================================
+ Coverage 84.29% 84.32% +0.03%
Complexity 80 80
============================================
Files 107 108 +1
Lines 522 523 +1
Branches 61 61
============================================
+ Hits 440 441 +1
Misses 26 26
Partials 56 56 ☔ View full report in Codecov by Sentry. |
I think it will be cleaner to have dedicated |
Also bump version to 6.8.1 here in this PR. |
Signed-off-by: Michael Oviedo <[email protected]>
8c2e74e
to
cfe856b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michael Oviedo <[email protected]>
cfe856b
to
d990de2
Compare
Signed-off-by: Michael Oviedo <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-6.x 6.x
# Navigate to the new working tree
pushd ../.worktrees/backport-6.x
# Create a new branch
git switch --create backport/backport-478-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b367e57d6fe69b0e03f5ad989726660015e7685
# Push it to GitHub
git push --set-upstream origin backport/backport-478-to-6.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-6.x Then, create a pull request where the |
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit 6b367e5)
…#479) Co-authored-by: Michael Oviedo <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-6.x 6.x
# Navigate to the new working tree
pushd ../.worktrees/backport-6.x
# Create a new branch
git switch --create backport/backport-478-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b367e57d6fe69b0e03f5ad989726660015e7685
# Push it to GitHub
git push --set-upstream origin backport/backport-478-to-6.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-6.x Then, create a pull request where the |
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit 6b367e5)
Description
Add compare logic to opensearch build libraries, update benchmark tests, create tests for compare commands.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.