Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jenkins tests with new execute-test command #471

Merged

Conversation

OVI3D0
Copy link
Member

@OVI3D0 OVI3D0 commented Aug 6, 2024

Description

update jenkins tests to call benchmark with new 'execute-test' command

Issues Resolved

#4837

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Michael Oviedo <[email protected]>
@OVI3D0 OVI3D0 force-pushed the update-benchmark-scripts branch from c341640 to b697c13 Compare August 6, 2024 17:13
@OVI3D0 OVI3D0 force-pushed the update-benchmark-scripts branch from c351860 to f71bd48 Compare August 6, 2024 20:29
@OVI3D0 OVI3D0 marked this pull request as ready for review August 6, 2024 20:30
Copy link
Collaborator

@rishabh6788 rishabh6788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (7ddabf2) to head (f71bd48).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #471   +/-   ##
=========================================
  Coverage     84.26%   84.26%           
  Complexity       80       80           
=========================================
  Files           106      106           
  Lines           521      521           
  Branches         61       61           
=========================================
  Hits            439      439           
  Misses           26       26           
  Partials         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -74,6 +74,7 @@ void call(Map args = [:]) {
def command = [
'./test.sh',
'benchmark-test',
args.command,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the param description like others at the top.

@rishabh6788 rishabh6788 merged commit 1042431 into opensearch-project:main Aug 6, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 6, 2024
Signed-off-by: Michael Oviedo <[email protected]>
(cherry picked from commit 1042431)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants