Fix grep bug in publishGradleCheckTestResults script #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <[email protected]>
rishabh6788
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
zelinh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
=========================================
Coverage 87.12% 87.12%
Complexity 31 31
=========================================
Files 88 88
Lines 233 233
Branches 12 12
=========================================
Hits 203 203
Misses 22 22
Partials 8 8 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
Apr 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 6d35e94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug related to grep expression in the script. Currently it will match all HTTP status codes including 404 which is not correct.
It only needs to match 200 status to check if an index already exists.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.