Refactor retrievePreviousBuild and buildManifest library #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
============================================
+ Coverage 87.01% 87.06% +0.05%
Complexity 31 31
============================================
Files 86 87 +1
Lines 231 232 +1
Branches 12 12
============================================
+ Hits 201 202 +1
Misses 22 22
Partials 8 8 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit 5a9bd97) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-6.x 6.x
# Navigate to the new working tree
pushd ../.worktrees/backport-6.x
# Create a new branch
git switch --create backport/backport-396-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a9bd970870c3b6c4c5500cc27d5c54d56b4f818
# Push it to GitHub
git push --set-upstream origin backport/backport-396-to-6.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-6.xThen, create a pull request where the |
zelinh
added a commit
to zelinh/opensearch-build-libraries
that referenced
this pull request
Mar 29, 2024
…project#396) Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit 5a9bd97)
gaiksaya
reviewed
Mar 29, 2024
| @@ -8,13 +8,25 @@ | |||
| */ | |||
| package jenkins.tests | |||
|
|
|||
| import org.junit.Test | |||
| import org.junit.* | |||
There was a problem hiding this comment.
Should have avoided wildcard here. junit has way too many subclasses. Please fix this in next iteration
zelinh
added a commit
to zelinh/opensearch-build-libraries
that referenced
this pull request
Mar 29, 2024
…project#396) Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit 5a9bd97) Signed-off-by: Zelin Hao <[email protected]>
zelinh
added a commit
that referenced
this pull request
Mar 29, 2024
…brary (#396) (#404) Signed-off-by: Zelin Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the latest index download to the buildManifest library.
Now if the
latestindex is not available, we would run the full build without incremental.Issues Resolved
#392
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.