Update the URL for latest index.json in retrievePreviousBuild library #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=========================================
Coverage 86.11% 86.11%
Complexity 29 29
=========================================
Files 82 82
Lines 216 216
Branches 12 12
=========================================
Hits 186 186
Misses 22 22
Partials 8 8 ☔ View full report in Codecov by Sentry. |
zelinh
force-pushed
the
update-latest-url
branch
6 times, most recently
from
621ccf3 to
aae1a80
Compare
Signed-off-by: Zelin Hao <[email protected]>
zelinh
force-pushed
the
update-latest-url
branch
from
aae1a80 to
31bb9f4
Compare
peterzhuamazon
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Have talk with @zelinh on this and the idea is to first check if the new index file is there. If not, fall back to the old latest index file.
Thanks.
|
@zelinh do you plan to bump the lib version? |
Could you help on incrementing the version? Thanks. |
Signed-off-by: Zelin Hao <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
…#367) Signed-off-by: Zelin Hao <[email protected]> (cherry picked from commit ae6bcad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the URL for latest index.json since we have a new uploading path for the
index.json.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.