Update getIndexFileRoot path in BuildManifest #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=========================================
Coverage 87.43% 87.43%
Complexity 29 29
=========================================
Files 81 81
Lines 207 207
Branches 11 11
=========================================
Hits 181 181
Misses 19 19
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Divyaasm
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
rishabh6788
approved these changes
Dec 22, 2023
prudhvigodithi
approved these changes
Dec 22, 2023
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
gaiksaya
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Can you also please bump the version here to 6.x? https://github.com/opensearch-project/opensearch-build-libraries/blob/main/.github/workflows/version-increment.yml#L36
Signed-off-by: Divya Madala <[email protected]>
gaiksaya
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return the new index.json file path w.r.t platform, architecture and distribution types.
Issues Resolved
opensearch-project/opensearch-build#4165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.