-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update createGithubIssue
to re-open recently closed issue
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvigodithi
requested review from
peterzhuamazon,
gaiksaya and
rishabh6788
as code owners
October 30, 2023 20:14
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 87.43% 87.43%
Complexity 29 29
=========================================
Files 81 81
Lines 207 207
Branches 11 11
=========================================
Hits 181 181
Misses 19 19
Partials 7 7
|
gaiksaya
reviewed
Oct 30, 2023
prudhvigodithi
force-pushed
the
main
branch
5 times, most recently
from
October 30, 2023 23:15
3d8702d
to
7dc2fbe
Compare
gaiksaya
reviewed
Oct 31, 2023
Signed-off-by: Prudhvi Godithi <[email protected]>
gaiksaya
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit d19c684) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
createGithubIssue
to re-open recently closed issueTesting: Library behaviour
JenkinsFile
New issue
prudhvigodithi/job-scheduler#27
Comment on existing issue
prudhvigodithi/job-scheduler#26 (comment)
Re-open and comment on recently closed issue
Re-open: prudhvigodithi/job-scheduler#26 (comment)
Comment: prudhvigodithi/job-scheduler#26 (comment)
Issues Resolved
opensearch-project/opensearch-build#4171
Coming from the logic opensearch-project/opensearch-build#4171 (comment)
Test with new option
daysToReOpen
When passed
daysToReOpen: "10"
goes back to 10 days from current date2023-10-20
When now passed
daysToReOpen
uses default 3 days from current date2023-10-27
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.