[Backport 5.x] Refactoring var scopes in uploadMinSnapshotsToS3 libs #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#318) Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
zelinh
approved these changes
Oct 4, 2023
Codecov Report
@@ Coverage Diff @@
## 5.x #323 +/- ##
=========================================
Coverage 87.37% 87.37%
Complexity 29 29
=========================================
Files 80 80
Lines 206 206
Branches 11 11
=========================================
Hits 180 180
Misses 19 19
Partials 7 7
|
peterzhuamazon
changed the title
gaiksaya
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Backport 5.x] Refactoring var scopes in uploadMinSnapshotsToS3 libs
Issues Resolved
#318
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.