Added groovy script for running benchmark tests #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
============================================
+ Coverage 85.42% 86.56% +1.14%
- Complexity 25 27 +2
============================================
Files 74 76 +2
Lines 199 201 +2
Branches 11 11
============================================
+ Hits 170 174 +4
+ Misses 21 19 -2
Partials 8 8
|
gaiksaya
requested changes
May 18, 2023
vars/runBenchmarkTestScript.groovy
Outdated
Comment on lines
13
to
18
| * @param args.insecure <required> - Force the security of the cluster to be disabled, default is false. | ||
| * @param args.workload <required> - Name of the workload that OpenSearch Benchmark should run, default is nyc_taxis. | ||
| * @param args.singleNode <required> - Create single node OS cluster, default is true. | ||
| * @param args.minDistribution <required> - Use min distribution of OpenSearch for cluster, default is false. | ||
| * @param args.useFiftyPercentHeap <required> - Use 50 percent of physical memory as heap, default is false. | ||
| * @param args.captureNodeStat <required> - Make opensearch-benchmark to capture node stats during run, default is false |
There was a problem hiding this comment.
All these values have defaults so they cannot be required. I believe they should be ?
There was a problem hiding this comment.
Makes sense, will make them optional.
There was a problem hiding this comment.
workload is a required field in the context of the groovy script, made others optional.
vars/runBenchmarkTestScript.groovy
Outdated
| lib = library(identifier: 'jenkins@main', retriever: legacySCM(scm)) | ||
| def buildManifest = lib.jenkins.BuildManifest.new(readYaml(file: args.bundleManifest)) | ||
|
|
||
| config_name = isNullOrEmpty(args.config) ? "config.yml" : args.config |
There was a problem hiding this comment.
I dont see config in args above. Was that missed?
vars/runBenchmarkTestScript.groovy
Outdated
| } | ||
|
|
||
| String getMetadataTags(tags, buildManifest) { | ||
| def metadataTags = "jenkins-build-id:${buildManifest.getArtifactBuildId()},arch:${buildManifest.getArtifactArchitecture()}," + |
There was a problem hiding this comment.
jenkins-build-id indicates the build number of the jenkins workflow where this will be run. Usually it means that.
How about distribution-build-id or dist-build-id?
There was a problem hiding this comment.
makes sense, updated.
Signed-off-by: Rishabh Singh <[email protected]>
gaiksaya
approved these changes
May 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 22, 2023
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 762ba18) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rishabh6788
pushed a commit
that referenced
this pull request
May 22, 2023
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 762ba18) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds groovy script to run benchmark tests using opensearch-benchmark.
Issues Resolved
opensearch-project/opensearch-build#3496
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.