Add library for publishing artifacts to crates.io #194
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon and
prudhvigodithi
as code owners
gaiksaya
changed the title
| } | ||
|
|
||
| void parameterCheck(String repository, String tag) { | ||
| if (!repository || !tag) { |
There was a problem hiding this comment.
This should be if (!repository && !tag)?
In the current implementation with ||, if there is NO repository but there IS a tag it will still error out.
Hopefully my jetlag mind is not messing this up. Thanks.
There was a problem hiding this comment.
Yes if either is not provided it should error out. We are checking the ! so || works here
There was a problem hiding this comment.
No you didnt get me there.
if there is NO repository but there IS a tag
with if (!repository || !tag), if there is NO repo, then the 1st condition is true, and it will never check the 2nd condition. Therefore, if there is also a tag, which makes the 2nd condition false, will never be tested and it will default to error out despite you have a tag but no repository.
There was a problem hiding this comment.
Yeah so I want to error out if there is a tag but no repository which is correct.
I believe what you are saying is if (repository && tag) which is equal to if (!repository || !tag) that I have above. So if either of them (or both) is not present it should throw an error.
I tested this. Works as expected.
There was a problem hiding this comment.
Have offline discussion with Sayali now, understand her intention is to test if tag exist when there IS a repository. If there is NO repository, then dont even need to care.
Suggest adding some comments on this in case the context is missed later, or just use 2 nested if condition for more clarity.
Thanks.
| checkout([$class: 'GitSCM', userRemoteConfigs: [[url: "${args.repository}" ]], branches: [[name: "${args.tag}" ]]]) | ||
|
|
||
| withCredentials([string(credentialsId: 'crates-api-token', variable: 'API_TOKEN')]) { | ||
| sh "cargo publish ${packageToPublish} --dry-run && cargo publish ${packageToPublish} --token ${API_TOKEN}" |
There was a problem hiding this comment.
What happens if a package is not passed?
There was a problem hiding this comment.
This is just out of curiosity to what exactly gets published. Approving.
There was a problem hiding this comment.
By default, the package in the current working directory is selected if package is not passed. Usually if there are more packages, cargo errors out asking to select a package exclusively.
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit c8033da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c8033da) Signed-off-by: Sayali Gaikawad <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds a library to publish rust artifacts to crates.io. The artifacts do not needs to be built similar to NPM. Also signing is not supported yet.
Issues Resolved
resolves #155
related opensearch-project/opensearch-build#3247
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.