Enhance S3 bucket to download from any bucket using any role #135
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 83.07% 83.07%
Complexity 24 24
=========================================
Files 70 70
Lines 195 195
Branches 11 11
=========================================
Hits 162 162
Misses 25 25
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| s3Download(file: args.destPath, bucket: args.bucket, path: args.path, force: args.force) | ||
| boolean forceDownload = args.force ?: false | ||
|
|
||
| withCredentials([string(credentialsId: "${args.roleAccountNumberCred}", variable: 'AWS_ACCOUNT_NUMBER')]) { |
There was a problem hiding this comment.
Should we ask team to put specific account number as credentialID here? This would expose the AWS account number right?
There was a problem hiding this comment.
Its jenkins credential id so AWS secrets manager name. ex: jenkins-aws-account-number which in AWS secrets manager will hold the actual account number
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh so we would need to store each of the account we would download from to the secret manager right?
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
force-pushed
the
modify-s3-download
branch
from
0aaf081 to
501f920
Compare
Description
This change makes the library flexible enough to download anything from any any S3 bucket using any role.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.