Add lib to sign and publish artifacts to artifacts.opensearch.org #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #127 +/- ##
============================================
+ Coverage 82.98% 83.07% +0.08%
Complexity 24 24
============================================
Files 69 70 +1
Lines 194 195 +1
Branches 11 11
============================================
+ Hits 161 162 +1
Misses 25 25
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaiksaya
force-pushed
the
artifacts-upload
branch
from
57978d6 to
c8552da
Compare
rishabh6788
reviewed
Feb 6, 2023
| @param Map[source] <required> - Path to yml or artifact file. | ||
| @param Map[destination] <required> - Artifact type in the manifest, [type] is required for signing yml. | ||
| @param Map[signingPlatform] <optional> - The distribution platform for signing. Defaults to linux | ||
| @param Map[sigtype] <optional> - signature type. Defaults to '.sig' |
rishabh6788
reviewed
Feb 6, 2023
| @param Map[destination] <required> - Artifact type in the manifest, [type] is required for signing yml. | ||
| @param Map[signingPlatform] <optional> - The distribution platform for signing. Defaults to linux | ||
| @param Map[sigtype] <optional> - signature type. Defaults to '.sig' | ||
| @param Map[overwrite]<optional> - Allow output artifacts to overwrite the existing artifacts. Defaults to false |
There was a problem hiding this comment.
Hey! So these args are supplied as it is to sign.sh so has to be sigtype and overwrite: https://github.com/opensearch-project/opensearch-build/blob/main/src/sign_workflow/sign_args.py#L45-L57
rishabh6788
approved these changes
Feb 6, 2023
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
force-pushed
the
artifacts-upload
branch
from
b2ba395 to
d2e63e7
Compare
Signed-off-by: Sayali Gaikawad <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-127-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09ba8285089488f9d0efbd789a4bb8bd01c6aab1
# Push it to GitHub
git push --set-upstream origin backport/backport-127-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
gaiksaya
added a commit
that referenced
this pull request
Feb 6, 2023
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 09ba828)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-127-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09ba8285089488f9d0efbd789a4bb8bd01c6aab1
# Push it to GitHub
git push --set-upstream origin backport/backport-127-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
gaiksaya
added a commit
that referenced
this pull request
Feb 6, 2023
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 09ba828)
gaiksaya
added a commit
that referenced
this pull request
Feb 6, 2023
…) (#132) Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 09ba828)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the library to sign and publish the artifacts to artifacts.opensearch.org. The role management is manual as of today but we are looking into automating the same.
Issues Resolved
required for opensearch-project/opensearch-build#3112
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.