Refactor build env logic to switch between testing and production #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
force-pushed
the
add-docker-unittest-x64
branch
from
609f6cd
to
79bfa17
Compare
peterzhuamazon
changed the title
peterzhuamazon
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
add-docker-unittest-x64
branch
from
63bf555
to
62eb77d
Compare
Signed-off-by: Peter Zhu <[email protected]>
gkamat
approved these changes
Aug 1, 2024
Comment on lines
+38
to
+41
| PLATFORM=${{ matrix.platform }} | ||
| PLATFORM=`echo $PLATFORM | tr '/' '-'` | ||
| docker buildx build --platform ${{ matrix.platform }} --build-arg BUILD_ENV=testing --build-arg BUILD_DATE=`date -u +%Y-%m-%dT%H:%M:%SZ` -f "docker/Dockerfile" -t "osb/osb-$PLATFORM" -o type=docker . | ||
| docker images | grep "osb/osb-$PLATFORM" |
There was a problem hiding this comment.
Probably can be streamlined, but fine for testing.
What does the docker images line do? Is it simply to print the output of the grep?
There was a problem hiding this comment.
Yes @gkamat
It is to setup the next step of running docker container based on the image just created.
In multi-arch build most of the time image has to be pushed upon completion to registry.
I force the image to be saved locally so we can use the image to run containers.
Once the container is up we can use it to run IT.
This is a pre-req before that happens.
And I agree the code can be streamlined a bit, which I will improve in the next iteration.
Thanks.
IanHoang
reviewed
Aug 2, 2024
There was a problem hiding this comment.
We need this file for integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Docker Run UnitTest on x64 Runner
Issues Resolved
opensearch-project/opensearch-build#4723
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.