Removing the duplicate process check based on truncated name and relying on cmdline check #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backslasht
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
…ing on cmdline check On linux, the process name is truncated to 15 characters and hence it matches both opensearch-benchmark and opensearch-benchmarkd. This results in killing the daemon process and breaks the distributed run setup. Removing the name based check on the truncated name and relying on command line which provides the full command. Keeping the name based check on full name as is. Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
backslasht
force-pushed
the
duplicate_osb_check
branch
from
0e2930a
to
89e0ec8
Compare
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
…ing on cmdline check (opensearch-project#553) Signed-off-by: Prabhakar Sithanandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On linux, the process name is truncated to 15 characters and hence it matches both opensearch-benchmark and opensearch-benchmarkd. This results in killing the daemon process and breaks the distributed run setup. Removing the name based check on the truncated name and relying on command line which provides the full command.
Keeping the name based check on full name as is.
Testing
Tested in Linux system and verified daemon process is excluded in duplicate process check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.