Package pbzip2 binaries, so they get installed automatically #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
Signed-off-by: Govind Kamat <[email protected]>
cgchinmay
approved these changes
Jun 26, 2024
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
…rch-project#551) Signed-off-by: Govind Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Package
pbzip2binaries for Linux and Darwin, so they are available even if the user does not explicitly install them. An updated install is still recommended, since there may be further architecture-specific improvements, but this strategy should still provide the bulk of the benefits available with using parallel decompressors.Support for
pigzwill be added in a separate change, for corpora that use that compression codec. The standard workloads usebzip2compression.Issues Resolved
#525
Testing
Verified the new binaries are getting picked up on different flavors and architectures of Linux. Ran unit and integ tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.