Download pre-generated offset file from data corpus repository, if present #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
force-pushed
the
offset-file
branch
3 times, most recently
from
3465685
to
8aac123
Compare
Signed-off-by: Govind Kamat <[email protected]>
gkamat
force-pushed
the
offset-file
branch
3 times, most recently
from
8aac123
to
6512064
Compare
cgchinmay
reviewed
May 26, 2024
| try: | ||
| self.downloader.download(document_set.base_url, None, doc_path + '.offset', None) | ||
| except exceptions.DataError as e: | ||
| if isinstance(e.cause, urllib.error.HTTPError) and (e.cause.code == 403 or e.cause.code == 404): |
There was a problem hiding this comment.
for file not found ,shouldn't error code be just 404 ?
There was a problem hiding this comment.
If there is no read permission enabled on the directory, there will be a 403 error code for non-existent files or objects.
There was a problem hiding this comment.
Got it. My comment was more in regards to the log message, since it had only "file not found" message, I was wondering why 403 is also included here. Thanks for clarifying
cgchinmay
approved these changes
May 26, 2024
|
This will expedite the downloading process. Thanks for doing this 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generation of the offset table that maps line numbers to file offsets for large data corpora can take a considerable amount of time. Downloading pre-generated offset files is much faster. This change implements this capability and downloads associated offset files when available.
Issues Resolved
#519
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.