Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print test_execution_id #492

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

cgchinmay
Copy link
Collaborator

@cgchinmay cgchinmay commented Mar 27, 2024

Description

[Describe what this change achieves]

display test execution id before running test for start and execution-test commands. These are the only 2 subcommands which use this argument.

Issues Resolved

[List any issues this PR will resolve]
#471

Testing

  • New functionality includes testing

[Describe how this change was tested]
Ran without custom test execution id

python3 osbenchmark/benchmark.py execute-test --pipeline=benchmark-only --workload=percolator --target-host=https://localhost:9200/ --client-options=basic_auth_user:admin,basic_auth_password:admin,verify_certs:false --test-mode                                     

[INFO] [Test Execution ID]: a7b0f002-573c-41c6-a2fb-8df7d9ad0ff6
[INFO] You did not provide an explicit timeout in the client options. Assuming default of 10 seconds.
[INFO] Executing test with workload [percolator], test_procedure [append-no-conflicts] and provision_config_instance ['external'] with version [2.12.0]

With custom id

python3 osbenchmark/benchmark.py execute-test --pipeline=benchmark-only --workload=percolator --target-host=https://localhost:9200/ --client-options=basic_auth_user:admin,basic_auth_password:admin,verify_certs:false --test-mode --test-execution-id "custom-test-123"

[INFO] [Test Execution ID]: custom-test-123

Validated make test


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chinmay Gadgil <[email protected]>
Copy link
Collaborator

@beaioun beaioun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanHoang IanHoang added the 1.5.0 label Mar 28, 2024
@IanHoang IanHoang merged commit 490ec84 into opensearch-project:main Mar 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants