Updating CCR telemetry device for OpenSearch. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkala
force-pushed
the
ccr
branch
7 times, most recently
from
222364d
to
99185c4
Compare
There was a problem hiding this comment.
For historical reasons I think it's worth updating the PR description to say that the CCR telemetry device used for xpack Elasticsearch is being replaced with one that works for OpenSearch.
Overall the changes look good to me though. I just have a few small suggestions.
ankitkala
changed the title
Yep. Just updated the PR with all changes. |
ankitkala
force-pushed
the
ccr
branch
2 times, most recently
from
c706645
to
a775a64
Compare
achitojha
approved these changes
Feb 1, 2022
Signed-off-by: Ankit Kala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankit Kala [email protected]
Description
This PR replaces the CCR telemetry logic used by xpack Elasticsearch with OpenSearch cross cluster replication plugin.
Issues Resolved
88
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.