Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/app-crash-fix: Fixed App Crashing Issue while changing PPL #943

Closed

Conversation

shankha-das
Copy link
Contributor

Description

  1. Resolved dimension issue for Time Series
  2. Resolved the issue which was crashing the app when PPL is changed

Issues Resolved

#942

@shankha-das shankha-das requested a review from a team as a code owner August 17, 2022 13:04
@shankha-das shankha-das changed the title Bug/app crash fix Bug/app-crash-fix: Fixed App Crashing Issue while changing PPL Aug 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #943 (62a6f48) into main (7cbe5d8) will increase coverage by 0.61%.
The diff coverage is 61.29%.

@@             Coverage Diff              @@
##               main     #943      +/-   ##
============================================
+ Coverage     55.42%   56.04%   +0.61%     
  Complexity      291      291              
============================================
  Files           262      262              
  Lines          8759     8786      +27     
  Branches       1923     1984      +61     
============================================
+ Hits           4855     4924      +69     
+ Misses         3733     3687      -46     
- Partials        171      175       +4     
Flag Coverage Δ
dashboards-observability 50.39% <61.29%> (+0.85%) ⬆️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/visualizations/charts/helpers/viz_types.ts 68.51% <60.00%> (-12.97%) ⬇️
...lorer/visualizations/config_panel/config_panel.tsx 68.75% <100.00%> (ø)
...mponents/event_analytics/hooks/use_fetch_events.ts 1.29% <0.00%> (ø)
...anes/config_controls/config_panel_option_gauge.tsx 11.76% <0.00%> (ø)
...ic/components/visualizations/charts/lines/line.tsx 34.04% <0.00%> (+2.12%) ⬆️
...ublic/components/visualizations/charts/bar/bar.tsx 62.28% <0.00%> (+45.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ruchika-narang ruchika-narang deleted the bug/app-crash-fix branch August 17, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants