Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint2 code refactoring and warning minimization #904

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Sprint2 code refactoring and warning minimization #904

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9484894
changes to remove for unique key warning on Dom and code refactoring …
rinku-kumar-psl Jul 28, 2022
ea9b470
snapshot updated
rinku-kumar-psl Jul 29, 2022
1576b24
no_results.test.tsx snapshot updated
rinku-kumar-psl Jul 29, 2022
cb856b8
added empty line at the end of the file
rinku-kumar-psl Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dashboards-observability/common/types/explorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,13 @@ export interface IVisualizationTypeDefination {
type: string;
id: string;
label: string;
fullLabel: string;
fulllabel: string;
category: string;
icon: React.ReactNode;
editorConfig: {
editorconfig: {
panelTabs: IConfigPanelTab;
};
visConfig: {
visconfig: {
layout: Partial<Plotly.Layout>;
config: Partial<Plotly.Config>;
};
Expand Down Expand Up @@ -247,4 +247,4 @@ export interface HistogramConfigList {
export interface ConfigList {
dimensions?: ConfigListEntry[] | HistogramConfigList[];
metrics?: ConfigListEntry[];
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty line at end.

Loading