Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint1 : combine PR for visualization from Sprint1 #824

Merged
merged 40 commits into from
Jul 8, 2022
Merged

Sprint1 : combine PR for visualization from Sprint1 #824

Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
ed78cff
graph style section UI schema
rinku-kumar-psl May 18, 2022
5f8ed2b
changes for style mode and interpolation
rinku-kumar-psl Jun 24, 2022
3da4b49
lineWidth integration for line mode
rinku-kumar-psl Jun 24, 2022
4a4207c
changes for Legend and Orientation in Line
rinku-kumar-psl Jun 24, 2022
790b33b
point size and Bar Alignment changes
rinku-kumar-psl Jun 24, 2022
b5a6191
implemented fill opacity for line chart
rinku-kumar-psl Jun 23, 2022
bae6b96
changes for line width and fill opacity in bar mode and removed mode …
rinku-kumar-psl Jun 24, 2022
c91c934
updated bar mode opacity in line chart
rinku-kumar-psl May 13, 2022
30e7e88
refactored the config chart style code
rinku-kumar-psl Jun 24, 2022
6e399da
snapshot updated and code refactored
rinku-kumar-psl Jun 23, 2022
8235008
type added to new component
rinku-kumar-psl Jun 24, 2022
68fd32a
review comments addressed
rinku-kumar-psl Jun 24, 2022
f2d3d32
cypress test case added and resolve button label wraping issue
rinku-kumar-psl Jun 24, 2022
a76ac36
multi matrices changes for Line
rinku-kumar-psl Jun 17, 2022
23373a1
dimensions and metrics UI changes for time-series
rinku-kumar-psl Jun 24, 2022
988e761
made data config pannel collapsable and initial fields render
rinku-kumar-psl Jun 24, 2022
2cb28f7
code refactored
rinku-kumar-psl Jun 24, 2022
e632d77
snapshot updated and handled corner cases
rinku-kumar-psl Jun 24, 2022
dbd564e
code styling fixes and added TODO comment
rinku-kumar-psl Jun 24, 2022
8e6769d
table view: eui table replaced with ag-grid
ramneet-persistent Jun 16, 2022
6789e81
drag-drop issue fixed
ramneet-persistent Jun 21, 2022
546130e
test case of data_table updated
ramneet-persistent Jun 23, 2022
3b54ee0
feedback comments resolved
ramneet-persistent Jun 23, 2022
4fbef03
grid height issue:fixed
ramneet-persistent Jun 23, 2022
61ed1b0
column height, value getter for type double
ramneet-persistent Jun 24, 2022
5a231a4
data_table elements moved to separate
ramneet-persistent Jun 24, 2022
6daacf3
footer components
ramneet-persistent Jun 24, 2022
c7c5a7c
cypress test cases for table view
ramneet-persistent Jun 24, 2022
6501581
data config reviewed code added
deepaknevdepsl Jun 24, 2022
8514ee3
Text correction
deepaknevdepsl Jun 24, 2022
a5ceefb
Conflicts resolved
deepaknevdepsl Jun 24, 2022
d1b6485
enhancement for heatmap with new UI
Jun 24, 2022
233a160
line chart test cases
Jun 24, 2022
dca1282
console logs removed
Jun 24, 2022
77a58b1
updated value options ui for treemap
mrunal-z Jun 24, 2022
d8374af
removed console
mrunal-z Jun 27, 2022
6bc9f46
sprint1-visualization-fixes.
abasatwar Jun 29, 2022
ba4d535
initialize default params for DimensonComponent and formatted the codes
rinku-kumar-psl Jul 7, 2022
268a49d
code review changes done
rinku-kumar-psl Jul 8, 2022
b6022c7
added empty line at end.
abasatwar Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
529 changes: 208 additions & 321 deletions dashboards-observability/.cypress/integration/1_event_analytics.spec.js
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions dashboards-observability/.cypress/utils/event_constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,31 @@ export const renderPieChart = () => {
cy.get('[data-test-subj="comboBoxToggleListButton"]').eq(0).click();
cy.get('[data-test-subj="comboBoxInput"]').eq(2).click();
};

export const renderDataConfig = () => {
cy.get('.euiResizablePanel.euiResizablePanel--middle').contains('Data Cofigurations');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please use data-test-subj where possible. Usually the cypress tests are flaky when we search by classname.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Going forward we will make sure of using data-test-subj wherever application in place of classname.

cy.get('.euiTitle.euiTitle--xxsmall').eq(1).contains('Dimensions').should('exist');
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(0).contains('Aggregation');
cy.get('[data-test-subj="comboBoxSearchInput"]').eq(0).click();
cy.get('.euiComboBoxOption__content').eq(2).click();
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(1).contains('Field');
cy.get('[data-test-subj="comboBoxSearchInput"]').eq(1).click();
cy.get('.euiComboBoxOption__content').eq(1).click();
cy.get('.euiFieldText[placeholder="Custom label"]').eq(0).type('Average field');
cy.get('.euiTitle.euiTitle--xxsmall').eq(2).contains('Metrics').should('exist');
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(0).contains('Aggregation');
cy.get('.euiFormRow__fieldWrapper .euiComboBox').eq(2).click();
cy.get('.euiComboBoxOption__content').eq(4).click();
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(4).click();
cy.get('.euiComboBoxOption__content').eq(0).click();
cy.get('.euiFieldText[placeholder="Custom label"]').eq(1).type('Min field');
cy.get('.euiButton__text').contains('Right').click();
cy.get('[data-test-subj="visualizeEditorRenderButton"]').contains('Update chart').click();
cy.get('.js-plotly-plot').should('exist');
};

export const renderLineChart = () => {
landOnEventVisualizations();
querySearch(TEST_QUERIES[5].query, TEST_QUERIES[5].dateRangeDOM);
cy.get('[data-test-subj="configPane__vizTypeSelector"] [data-test-subj="comboBoxInput"]').type('Line').type('{enter}');
};
16 changes: 16 additions & 0 deletions dashboards-observability/common/constants/data_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

export const GRID_HEADER_COLUMN_MAX_WIDTH = '150px';
export const GRID_PAGE_RANGE_DISPLAY = 5;
export const COLUMN_DEFAULT_MIN_WIDTH = 100;
export const GRID_PAGE_SIZES = [10, 50, 100];
export const ROW_DENSITIES = [
{ icon: 'tableDensityExpanded', height: 55, selected: false },
{ icon: 'tableDensityNormal', height: 45, selected: false },
{ icon: 'tableDensityCompact', height: 35, selected: true },
];

export const HEADER_HEIGHT = 35;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the data table is used inside event analytics let's move this to constants/explorer.ts, if shared by other components let's move to constants/shard.ts

14 changes: 14 additions & 0 deletions dashboards-observability/common/types/explorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,17 @@ export interface LiveTailProps {
isLiveTailPopoverOpen: boolean;
dataTestSubj: string;
}

export interface ConfigListEntry {
label: string;
aggregation: string;
custom_label: string;
name: string;
side: string;
type: string;
}

export interface ConfigList {
dimensions?: ConfigListEntry[];
metrics?: ConfigListEntry[];
}
3 changes: 3 additions & 0 deletions dashboards-observability/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@
"@nteract/outputs": "^3.0.11",
"@nteract/presentational-components": "^3.4.3",
"@reduxjs/toolkit": "^1.6.1",
"ag-grid-community": "^27.3.0",
"ag-grid-react": "^27.3.0",
Comment on lines +20 to +21
Copy link
Member

@ps48 ps48 Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add this new dependency? Is there an issue/document where we discussed what was not available in EUI components. Adding more packages, puts lot more maintenance issues in long term. Thus, we should have strong reasons to support addition of this package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ps48 ,
We have changed table view implementation as per https://github.com/opensearch-project/observability/issues/772.And as per new implementation, new dependencies are added and we have confirmed it on call and tkt too.

thanks,
Amruta

"plotly.js-dist": "^2.2.0",
"react-graph-vis": "^1.0.5",
"react-paginate": "^8.1.3",
"react-plotly.js": "^2.5.1"
},
"devDependencies": {
Expand Down
Loading