Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notebook cypress tests #637

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Apr 11, 2022

Signed-off-by: Shenoy Pratik [email protected]

Description

updated notebook cypress tests, added data cleanup and updated eui 2.0 toggle button clicks

Issues Resolved

#628

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 requested a review from a team as a code owner April 11, 2022 20:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #637 (4c19b5d) into main (aa125b4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #637   +/-   ##
=========================================
  Coverage     55.16%   55.16%           
  Complexity      283      283           
=========================================
  Files           240      240           
  Lines          7697     7697           
  Branches       1572     1572           
=========================================
  Hits           4246     4246           
  Misses         3281     3281           
  Partials        170      170           
Flag Coverage Δ
dashboards-observability 46.83% <ø> (ø)
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa125b4...4c19b5d. Read the comment docs.

Copy link
Collaborator

@kavithacm kavithacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cy.wait(100);
cy.get('.euiButton__text').contains('Yes').trigger('mouseover').click();
cy.wait(100 * 5);
cy.route2('POST', '/addSamplePanels').as('addSamples');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to load sample observability data. The data is used to add a sample observability visualization in notebooks.

@ps48 ps48 merged commit ecfd2f9 into opensearch-project:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants