Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated panel flaky cypress tests #633

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Apr 8, 2022

Signed-off-by: Shenoy Pratik [email protected]

Description

Fixing flaky tests and tests failing due to 2.0 version update

Issues Resolved

#628

  1. Fixed type input/focus issues
  2. Added intercept instead of delay for async request

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 requested a review from a team as a code owner April 8, 2022 18:19
@ps48 ps48 changed the title Updated panel flaky tests Updated panel flaky cypress tests Apr 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #633 (a13ac68) into main (533eda1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #633   +/-   ##
=========================================
  Coverage     55.16%   55.16%           
  Complexity      283      283           
=========================================
  Files           240      240           
  Lines          7697     7697           
  Branches       1572     1572           
=========================================
  Hits           4246     4246           
  Misses         3281     3281           
  Partials        170      170           
Flag Coverage Δ
dashboards-observability 46.83% <ø> (ø)
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533eda1...a13ac68. Read the comment docs.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in future are we going to update tests in both places (here and dashboards-functional-test) or removing tests here and only update dashboards-functional-test repo? or not decided yet

@ps48
Copy link
Member Author

ps48 commented Apr 8, 2022

in future are we going to update tests in both places (here and dashboards-functional-test) or removing tests here and only update dashboards-functional-test repo? or not decided yet

Not decided yet. For now once the tests are stable we'll just update them in func. tests repo

@ps48 ps48 merged commit aa125b4 into opensearch-project:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants