Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit visualization time change #617

Merged

Conversation

eugenesk24
Copy link
Contributor

Description

  • If visualization is saved with timeRange A, then even if application is at timeRange B, when you edit visualization it shows timeRange A

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.56%. Comparing base (84e56a2) to head (db61e34).
Report is 203 commits behind head on main.

Files with missing lines Patch % Lines
...lic/components/custom_panels/custom_panel_view.tsx 0.00% 1 Missing ⚠️
...isualization_container/visualization_container.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #617      +/-   ##
============================================
+ Coverage     54.54%   54.56%   +0.02%     
  Complexity      283      283              
============================================
  Files           239      239              
  Lines          7795     7792       -3     
  Branches       1605     1603       -2     
============================================
  Hits           4252     4252              
+ Misses         3371     3369       -2     
+ Partials        172      171       -1     
Flag Coverage Δ
dashboards-observability 46.15% <75.00%> (+0.02%) ⬆️
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eugenesk24 eugenesk24 marked this pull request as ready for review March 30, 2022 21:45
@eugenesk24 eugenesk24 requested a review from a team as a code owner March 30, 2022 21:45
@eugenesk24 eugenesk24 merged commit 2c3614c into opensearch-project:main Mar 30, 2022
@eugenesk24 eugenesk24 deleted the edit-visualization-time-change branch March 30, 2022 23:34
eugenesk24 added a commit to eugenesk24/trace-analytics that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants