Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow app creation with one composition #557

Merged
merged 8 commits into from
Mar 9, 2022
Merged

Allow app creation with one composition #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4511986
Disable stats/rare/head/top in base query autocompletion
eugenesk24 Mar 9, 2022
7430f92
Autocomplete suggest more indices
eugenesk24 Mar 9, 2022
2c9755e
Allow application to be created with only one composition
eugenesk24 Mar 9, 2022
c637075
Enable adding trace filter from dashboard table
eugenesk24 Mar 9, 2022
1a12de4
Fix ppl link being in weird places for panels
eugenesk24 Mar 9, 2022
7e82c0d
remove unnecessary import
eugenesk24 Mar 9, 2022
34d8fbe
Update snapshots
eugenesk24 Mar 9, 2022
edc84c2
Update autocomplete test for multiple index suggestion
eugenesk24 Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions dashboards-observability/.cypress/integration/app_analytics.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,18 @@ describe('Creating application', () => {
it('Disables create button if missing fields', () => {
expectMessageOnHover('Name is required.');
cy.get('[data-test-subj="nameFormRow"]').type(name);
expectMessageOnHover('Log Source is required.');
expectMessageOnHover('Provide at least one log source, service, entity or trace group.');
cy.get('.euiAccordion').contains('Log source').click();
cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(baseQuery);
expectMessageOnHover('Services & Entities is required.');
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiButton').contains('Create').should('not.be.disabled');
cy.get('[data-test-subj="searchAutocompleteTextArea"]').clear();
expectMessageOnHover('Provide at least one log source, service, entity or trace group.');
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('[data-test-subj="servicesEntitiesComboBox"]').click();
cy.get('.euiFilterSelectItem').contains(service_one).trigger('click');
cy.get('.euiBadge').contains('1').should('exist');
expectMessageOnHover('Trace Groups are required.');
cy.get('.euiButton').contains('Create').should('not.be.disabled');
cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(baseQuery);
cy.get('.euiAccordion').contains('Trace groups').click();
cy.get('[data-test-subj="traceGroupsComboBox"]').type('http');
cy.get('.euiFilterSelectItem').contains(trace_one).trigger('click');
Expand Down Expand Up @@ -78,7 +81,7 @@ describe('Creating application', () => {
cy.get('[data-test-subj="descriptionFormRow"]').type('This application is for testing.');
cy.get('.euiAccordion').contains('Log source').click();
cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(baseQuery);
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('[data-test-subj="servicesEntitiesComboBox"]').click();
cy.get('.euiFilterSelectItem').contains(service_one).trigger('click');
cy.get('.euiBadge').contains('1').should('exist');
Expand Down Expand Up @@ -106,7 +109,7 @@ describe('Creating application', () => {
cy.get('[data-test-subj="descriptionFormRow"]').type(description);
cy.get('.euiAccordion').contains('Log source').click();
cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(baseQuery);
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('[data-test-subj="servicesEntitiesComboBox"]').click();
cy.get('.euiFilterSelectItem').contains(service_one).trigger('click');
cy.get('.euiBadge').contains('1').should('exist');
Expand All @@ -132,7 +135,7 @@ describe('Creating application', () => {
cy.get('.euiButton').contains('Clear').click();
cy.get('.euiButton--danger').contains('Clear').click();
cy.get('[data-test-subj="searchAutocompleteTextArea"]').should('contain.value', '');
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('[data-test-subj="servicesEntitiesComboBox"]').click();
cy.get('.euiFilterSelectItem').contains(service_one).trigger('click');
cy.get('.euiBadge').contains('1').should('exist');
Expand All @@ -142,7 +145,7 @@ describe('Creating application', () => {
cy.get('.euiButton--danger').contains('Clear all').click();
cy.get('.euiBadge').contains('1').should('not.exist');
cy.get('.euiBadge').contains('0').should('exist');
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('.euiAccordion').contains('Trace groups').click();
cy.get('[data-test-subj="traceGroupsComboBox"]').type('http');
cy.get('.euiFilterSelectItem').contains(trace_one).trigger('click');
Expand Down Expand Up @@ -321,7 +324,7 @@ describe('Editing application', () => {
cy.get('[data-test-subj="comboBoxToggleListButton"]').filter(':visible').click();
cy.get('.euiFilterSelectItem').contains(trace_three).trigger('click');
cy.get('.euiBadge').contains('3').should('exist');
cy.get('.euiAccordion').contains('Services & Entities').click();
cy.get('.euiAccordion').contains('Services & entities').click();
cy.get('[data-test-subj="servicesEntitiesComboBox"]').click();
cy.get('.euiFilterSelectItem').contains(service_two).trigger('click');
cy.get('.euiBadge').contains('2').should('exist');
Expand Down
70 changes: 34 additions & 36 deletions ...lity/public/components/application_analytics/__tests__/__snapshots__/create.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -445,7 +445,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -1587,7 +1587,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -1654,7 +1654,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -2733,7 +2733,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -2800,7 +2800,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -3853,7 +3853,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -3920,7 +3920,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -5032,7 +5032,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -5102,7 +5102,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -6152,7 +6152,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -6222,7 +6222,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -7319,7 +7319,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -7386,7 +7386,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -8377,7 +8377,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -8444,7 +8444,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -9504,7 +9504,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -9571,7 +9571,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -10201,8 +10201,7 @@ Object {
class="euiToolTipAnchor"
>
<button
class="euiButton euiButton--primary euiButton--fill euiButton-isDisabled"
disabled=""
class="euiButton euiButton--primary euiButton--fill"
type="button"
>
<span
Expand Down Expand Up @@ -10593,7 +10592,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -10660,7 +10659,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -11290,8 +11289,7 @@ Object {
class="euiToolTipAnchor"
>
<button
class="euiButton euiButton--primary euiButton--fill euiButton-isDisabled"
disabled=""
class="euiButton euiButton--primary euiButton--fill"
type="button"
>
<span
Expand Down Expand Up @@ -11739,7 +11737,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -11809,7 +11807,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -12859,7 +12857,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -12929,7 +12927,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -14038,7 +14036,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -14105,7 +14103,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -15158,7 +15156,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -15225,7 +15223,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -16341,7 +16339,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -16408,7 +16406,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down Expand Up @@ -17546,7 +17544,7 @@ Object {
class="euiText euiText--small"
>
<h3>
Services & Entities
Services & entities
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(211, 218, 230); color: rgb(0, 0, 0);"
Expand Down Expand Up @@ -17613,7 +17611,7 @@ Object {
class="euiFormLabel euiFormRow__label"
for="random_html_id"
>
Services & Entities
Services & entities
</label>
</div>
<div
Expand Down
Loading