Add Bwc test for Observability #310

kavithacm · 2021-12-10T00:52:36Z

Description

Add bwc specific Integration Test
Update gradle.build to run bwc tests from opensearch 1.1 to opensearch 1.2
Included snapshot of Notebooks 1.1 and Observability 1.2

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Bump prismjs from 1.24.1 to 1.25.0 (opensearch-project#137) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump immer from 9.0.5 to 9.0.6 (opensearch-project#136) Bumps [immer](https://github.com/immerjs/immer) from 9.0.5 to 9.0.6. - [Release notes](https://github.com/immerjs/immer/releases) - [Commits](immerjs/immer@v9.0.5...v9.0.6) --- updated-dependencies: - dependency-name: immer dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Redirect legacy notebooks URL to current observability one (opensearch-project#141) * Move observability frontend to a sub directory (opensearch-project#142) * Add minimal plugin for backend observability (opensearch-project#143) * Add models for objects and requests (opensearch-project#144) * Add CRUD actions and index operations for observability objects (opensearch-project#145) * Update data modal and enable CI (opensearch-project#148) * Panels' visualization design change (opensearch-project#149) * modified common files * modified UI components * modified panel adaptor and router * moved loading to post http call * fixed prettier quotes * Feature timestamp (opensearch-project#152) * timestamp related changes Signed-off-by: Eric Wei <[email protected]> * cleanup Signed-off-by: Eric Wei <[email protected]> * removed loggings and change to console error Signed-off-by: Eric Wei <[email protected]> * remove unused sidebar component Signed-off-by: Eric Wei <[email protected]> * adding cancel button for edit & panel actions (opensearch-project#153) * Feature toasts errors handling (opensearch-project#155) * timestamp related changes Signed-off-by: Eric Wei <[email protected]> * cleanup Signed-off-by: Eric Wei <[email protected]> * removed loggings and change to console error Signed-off-by: Eric Wei <[email protected]> * remove unused sidebar component Signed-off-by: Eric Wei <[email protected]> * added toasts Signed-off-by: Eric Wei <[email protected]> * resolved build failure Signed-off-by: Eric Wei <[email protected]> * couple of error handling changes Signed-off-by: Eric Wei <[email protected]> * added types Signed-off-by: Eric Wei <[email protected]> * Autocomplete only displays current command (opensearch-project#157) * Only show current command in suggestion Signed-off by: Eugene Lee <[email protected]> * Remove console logs Signed-off by: Eugene Lee <[email protected]> * Only display suggestion Signed-off by: Eugene Lee <[email protected]> * Removed commas Signed-off by: Eugene Lee <[email protected]> * Remove import Signed-off by: Eugene Lee <[email protected]> * changed to support query without 'search' prefix (opensearch-project#158) Signed-off-by: Eric Wei <[email protected]> * Remove app analytics (opensearch-project#154) * removing app analytics from sidenav * removed unused headers * added trace analytics as default page * Use JS API to redirect legacy notebooks URL (opensearch-project#162) * Panels bug fix#1 (opensearch-project#159) * fixed UI bugs #1 * folder name typo fix * changes for adopting new sql artifact (opensearch-project#165) * changes for adopting new sql artifact Signed-off-by: Eric Wei <[email protected]> * minor changes Signed-off-by: Eric Wei <[email protected]> * Improve reindex handling for .opensearch-notebooks (opensearch-project#163) * inherited datepicker format from settings (opensearch-project#164) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: eugenesk24 <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

…-test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

…-test

codecov-commenter · 2021-12-10T00:55:19Z

Codecov Report

Merging #310 (8720daa) into main (da0cc10) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #310   +/-   ##
=========================================
  Coverage     71.86%   71.86%           
  Complexity      269      269           
=========================================
  Files            81       81           
  Lines          2804     2804           
  Branches        334      334           
=========================================
  Hits           2015     2015           
  Misses          624      624           
  Partials        165      165

Flag	Coverage Δ
dashboards-observability	`63.87% <ø> (ø)`
opensearch-observability	`74.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rg/opensearch/observability/ObservabilityPlugin.kt	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0cc10...8720daa. Read the comment docs.

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

davidcui1225 · 2021-12-10T01:05:37Z

DCO check is failing- also I see commits from a few months ago that don't look related to the BWC testing?

joshuali925

could you try to remove the resource/bwc/1.2.0-SNAPSHOT/opensearch-observability-1.2.0.0-SNAPSHOT.zip file and see if it works? trying to reduce git overhead

joshuali925 · 2021-12-10T01:14:53Z

opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt

@@ -165,9 +168,13 @@ abstract class PluginRestTestCase : OpenSearchRestTestCase() {
            exception.response
        }
        if (expectedRestStatus != null) {
+//            println("response is $response")


could you remove these comments

yeah okay. I'll remove them

davidcui1225 · 2021-12-10T01:17:31Z

opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt

@@ -165,9 +168,13 @@ abstract class PluginRestTestCase : OpenSearchRestTestCase() {
            exception.response
        }
        if (expectedRestStatus != null) {
+//            println("response is $response")


Can we remove any commented-out lines of they are not necessary?

yeah okay. I'll remove them

davidcui1225 · 2021-12-10T01:19:05Z

opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt

    @Throws(IOException::class)
    @After
    open fun wipeAllOpenSearchIndices() {
+        if (preserveOpenSearchIndicesAfterTest()) return


When does this if condition trigger?

this condition is set true in the IT created for bwc testing, so whenever BWC IT get's triggered this condition is triggered too

kavithacm · 2021-12-10T01:20:12Z

DCO check is failing- also I see commits from a few months ago that don't look related to the BWC testing?

Yeah those commits are not related to bwc and i'm not sure how it was included in this, but i removed those unnecessary files

davidcui1225 · 2021-12-10T01:23:45Z

DCO check is failing- also I see commits from a few months ago that don't look related to the BWC testing?

Yeah those commits are not related to bwc and i'm not sure how it was included in this, but i removed those unnecessary files

Got it - my guess is maybe some leftover local branch that contained those old commits was used at some point. Could you resolve the DCO failure?

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

kavithacm · 2021-12-10T01:39:53Z

DCO check is failing- also I see commits from a few months ago that don't look related to the BWC testing?

Yeah those commits are not related to bwc and i'm not sure how it was included in this, but i removed those unnecessary files

Got it - my guess is maybe some leftover local branch that contained those old commits was used at some point. Could you resolve the DCO failure?

Yeah i'm trying that currently

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

…lized_api profiler/api: Conform the changes in the WriteRaw API

kavithacm and others added 30 commits October 18, 2021 13:55

Create history_table.tsx

9bd5b7e

Update history_table.tsx

97b09cb

Update home.tsx

78513c4

Update history_table.tsx

276a590

Update history_table.tsx

693b261

Update home.tsx

ba84e8d

Update home.tsx

f6cd878

Delete home.tsx

e7783f8

Merge branch 'opensearch-project:main' into main

6487a5a

Merge branch 'opensearch-project:main' into main

e1437d3

Merge branch 'opensearch-project:main' into main

a7266dc

Merge branch 'opensearch-project:main' into main

e1fdf53

Merge branch 'opensearch-project:main' into main

616f98a

Merge branch 'opensearch-project:main' into main

34eb7b1

bwc-test

e0dfe5f

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

bwc-test

f36a5b9

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

update bwc test

190fd77

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

updated bwc test passes build

1b33e31

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Merge branch 'opensearch-project:main' into bwc-test

007d30c

update bwc along with snapshots

133370a

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

update gradle uild for remote integTest

905d8dc

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Merge remote-tracking branch 'refs/remotes/kavitha/bwc-test' into bwc…

8f36314

…-test

add notebooks 1.1 IT

b5b90f0

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Merge branch 'opensearch-project:main' into bwc-test

ac6c57b

exclude bwc test from build and change notificationIT

dba9253

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

change notificationIT uri

2899b83

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

change notificationIT uri

9ad14e3

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

change old cluster task

f97fced

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

change old cluster task

39dbded

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

kavithacm added 8 commits December 8, 2021 09:40

add integTest to Bwc test file

697ea44

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

update BWc file

1677473

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

update mixed cluster

4604064

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

bwc and gradle build passed

902dd8c

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Merge branch 'opensearch-project:main' into bwc-test

b42c5e7

delete redundant file

077211f

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

remove commented lines

97ee55e

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Merge remote-tracking branch 'refs/remotes/kavitha/bwc-test' into bwc…

8720daa

…-test

kavithacm requested a review from a team December 10, 2021 00:52

kavithacm self-assigned this Dec 10, 2021

delete redundant file

d683d10

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

kavithacm force-pushed the bwc-test branch from 8720daa to d683d10 Compare December 10, 2021 01:01

joshuali925 reviewed Dec 10, 2021

View reviewed changes

davidcui1225 reviewed Dec 10, 2021

View reviewed changes

kavithacm added 2 commits December 9, 2021 17:35

remove commented lines

0adf9cf

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

remove commented lines

911d50c

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

remove space

3b750a4

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

kavithacm closed this Dec 10, 2021

joshuali925 mentioned this pull request Dec 10, 2021

Add BWC test for Observability #314

Merged

6 tasks

joshuali925 pushed a commit to joshuali925/observability that referenced this pull request Jul 20, 2022

Merge pull request opensearch-project#310 from kakkoyun/conform_norma…

9f6fea3

…lized_api profiler/api: Conform the changes in the WriteRaw API

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bwc test for Observability #310

Add Bwc test for Observability #310

kavithacm commented Dec 10, 2021

codecov-commenter commented Dec 10, 2021 •

edited

Loading

davidcui1225 commented Dec 10, 2021

joshuali925 left a comment

joshuali925 Dec 10, 2021

kavithacm Dec 10, 2021

davidcui1225 Dec 10, 2021

kavithacm Dec 10, 2021

davidcui1225 Dec 10, 2021

kavithacm Dec 10, 2021

kavithacm commented Dec 10, 2021

davidcui1225 commented Dec 10, 2021

kavithacm commented Dec 10, 2021

Add Bwc test for Observability #310

Add Bwc test for Observability #310

Conversation

kavithacm commented Dec 10, 2021

Description

Issues Resolved

Check List

codecov-commenter commented Dec 10, 2021 • edited Loading

Codecov Report

davidcui1225 commented Dec 10, 2021

joshuali925 left a comment

Choose a reason for hiding this comment

joshuali925 Dec 10, 2021

Choose a reason for hiding this comment

kavithacm Dec 10, 2021

Choose a reason for hiding this comment

davidcui1225 Dec 10, 2021

Choose a reason for hiding this comment

kavithacm Dec 10, 2021

Choose a reason for hiding this comment

davidcui1225 Dec 10, 2021

Choose a reason for hiding this comment

kavithacm Dec 10, 2021

Choose a reason for hiding this comment

kavithacm commented Dec 10, 2021

davidcui1225 commented Dec 10, 2021

kavithacm commented Dec 10, 2021

codecov-commenter commented Dec 10, 2021 •

edited

Loading