create integrations index if it does not exist and define the integrations document #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
changed the title
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
|
Is this being repurposed per #1521 or should we close it? |
* create integrations index if it does not exist Signed-off-by: Derek Ho <[email protected]> * Create Integration Index class Signed-off-by: Simeon Widdis <[email protected]> * Add integration object doc Signed-off-by: Simeon Widdis <[email protected]> * Remove manual creation in integration index Signed-off-by: Simeon Widdis <[email protected]> * Add Integration object Signed-off-by: Simeon Widdis <[email protected]> * Add tests for integration class Signed-off-by: Simeon Widdis <[email protected]> * Add WIP create integration workflow Signed-off-by: Simeon Widdis <[email protected]> * we fixed it Signed-off-by: Derek Ho <[email protected]> * Fix integration file names Signed-off-by: Simeon Widdis <[email protected]> * Fix typo file Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
YANG-DB
approved these changes
May 3, 2023
| import org.opensearch.observability.util.logger | ||
|
|
||
| /** | ||
| * Application main data class. |
There was a problem hiding this comment.
the javadoc is not relevant to this example...
| import org.opensearch.observability.util.logger | ||
|
|
||
| /** | ||
| * Application main data class. |
There was a problem hiding this comment.
javadoc here again not representing the content ...
| class CreateIntegrationRequest : ActionRequest, ToXContentObject { | ||
| val objectId: String? | ||
| val type: IntegrationObjectType | ||
| val objectData: BaseObjectData? |
There was a problem hiding this comment.
why doesn’t this request accept a specific IntegrationRequest class ?
| import org.opensearch.common.io.stream.Writeable | ||
| import org.opensearch.core.xcontent.XContentParser | ||
|
|
||
| internal object IntegrationObjectDataProperties { |
There was a problem hiding this comment.
missing the integration actual fields - see here
| val tenant: String, | ||
| val access: List<String>, // "User:user", "Role:sample_role", "BERole:sample_backend_role" | ||
| val type: IntegrationObjectType, | ||
| val objectData: BaseObjectData? |
There was a problem hiding this comment.
why not having the concrete ObjectDataProperties here?
|
Closing since it moved to the front end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.