Add publish snapshots to maven via GHA #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
|
Local test output |
|
Hi @rupal-bq, shouldn't the name be |
…search-observability Signed-off-by: Rupal Mahajan <[email protected]>
Thanks for noticing. Output after adding rootProject.name = 'opensearch-observability' |
ps48
approved these changes
Feb 21, 2023
derek-ho
approved these changes
Feb 21, 2023
Hey! Looks like it is still publishing observability as well as opensearch-observability? Can you recheck? Not sure if these were previous artifacts. Make clean the directory and then republish? |
Sorry, I forgot to clear the directory. Output with clean directory |
gaiksaya
approved these changes
Feb 21, 2023
|
Added the secret role. You are good to merge. |
|
Hey to avoid confusion in future, please add |
YANG-DB
approved these changes
Feb 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Add publish snapshots to maven via GHA Signed-off-by: Rupal Mahajan <[email protected]> * Add rootProject name in seetings.gradle to change plugin name to opensearch-observability Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 298bf9f)
|
Looks like the workflow is failing @rupal-bq https://github.com/opensearch-project/observability/actions/runs/4236736463/jobs/7361884843 |
I think it's failing because job-scheduler is missing. I see job scheduler PR isn't merged yet. Reporting also has same error and depends on job-scheduler. |
|
I think this is the PR that needs to go in opensearch-project/job-scheduler#321 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Add publish snapshots to maven via GHA Signed-off-by: Rupal Mahajan <[email protected]> * Add rootProject name in seetings.gradle to change plugin name to opensearch-observability Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 298bf9f)
joshuali925
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 298bf9f) Co-authored-by: Rupal Mahajan <[email protected]>
YANG-DB
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Add publish snapshots to maven via GHA Signed-off-by: Rupal Mahajan <[email protected]> * Add rootProject name in seetings.gradle to change plugin name to opensearch-observability Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 298bf9f) Co-authored-by: Rupal Mahajan <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1417-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 298bf9f1e7b89b468e7a1756b945256090fde339
# Push it to GitHub
git push --set-upstream origin backport/backport-1417-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#1414
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.