Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Releases based on Tagging #1410

Closed
wants to merge 6 commits into from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Feb 15, 2023

Description

Generating a GitHub Release involves a few steps: selecting the commit, creating a version bump, and creating the release notes file. Per work mentioned in #1406, this has been automated to be performed based on tag selection. This PR:

  • Modifies the release label policy in draft-release-notes-config.yml to better reflect labels currently in use
    • Includes two new labels, infrastructure and skip-changelog, that need to be added to the repo
  • Implements the auto-release workflow from OpenSearch/auto-release.yml at main · opensearch-project/OpenSearch, see auto-release.yml
  • Adds a policy for enforcing that future PRs are appropriately labeled for more robust release notes, see enforce-labels.yml

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Swiddis Swiddis requested a review from a team as a code owner February 15, 2023 18:49
# Organizing the tagged PRs into unified categories
categories:
- title: 'Breaking Changes'
labels:
- 'Breaking Changes'
- 'breaking'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking-changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a breaking label but no breaking-changes one, is there a difference between them that warrants having both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upto you, somehow only breaking word didn't make sense to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a >breaking label is used in the OpenSearch repo. For consistency maybe we should go with this?

@vmmusings
Copy link
Member

The current state of the draft release is looking like this: https://github.com/opensearch-project/observability/releases/tag/2.1.0.0
Are we in good place for next release. Do we need to any cleanup on the existing draft release.

YANG-DB
YANG-DB previously approved these changes Feb 15, 2023
derek-ho
derek-ho previously approved these changes Feb 16, 2023
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derek-ho
Copy link
Collaborator

The current state of the draft release is looking like this: https://github.com/opensearch-project/observability/releases/tag/2.1.0.0 Are we in good place for next release. Do we need to any cleanup on the existing draft release.

This may only be from next release onwards, unless we want to go back and manually tag all PRs going into 2.6

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
derek-ho
derek-ho previously approved these changes Feb 16, 2023
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

@Swiddis Swiddis requested review from vmmusings and YANG-DB and removed request for vmmusings February 16, 2023 19:31
YANG-DB
YANG-DB previously approved these changes Feb 17, 2023
@ps48
Copy link
Member

ps48 commented Feb 21, 2023

@Swiddis should we add the infrastructure label to this PR?

@Swiddis
Copy link
Collaborator Author

Swiddis commented Feb 22, 2023

@Swiddis should we add the infrastructure label to this PR?

Yeah, the SQL repo defines infrastructure as "Changes to infrastructure, testing, CI/CD, pipelines, etc."

Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis dismissed stale reviews from YANG-DB and derek-ho via b0fe5db February 23, 2023 17:15
@Swiddis Swiddis changed the base branch from main to 2.x February 24, 2023 17:53
@Swiddis Swiddis changed the base branch from 2.x to main February 24, 2023 17:54
@Swiddis
Copy link
Collaborator Author

Swiddis commented Feb 24, 2023

Closing to re-base onto 2.x

@Swiddis Swiddis closed this Feb 24, 2023
@Swiddis Swiddis mentioned this pull request Feb 24, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto github release workflow
5 participants