-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Releases based on Tagging #1410
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
# Organizing the tagged PRs into unified categories | ||
categories: | ||
- title: 'Breaking Changes' | ||
labels: | ||
- 'Breaking Changes' | ||
- 'breaking' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking-changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a breaking
label but no breaking-changes
one, is there a difference between them that warrants having both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upto you, somehow only breaking word didn't make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a >breaking
label is used in the OpenSearch repo. For consistency maybe we should go with this?
The current state of the draft release is looking like this: https://github.com/opensearch-project/observability/releases/tag/2.1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This may only be from next release onwards, unless we want to go back and manually tag all PRs going into 2.6 |
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
@Swiddis should we add the |
Yeah, the SQL repo defines infrastructure as "Changes to infrastructure, testing, CI/CD, pipelines, etc." |
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Closing to re-base onto 2.x |
Description
Generating a GitHub Release involves a few steps: selecting the commit, creating a version bump, and creating the release notes file. Per work mentioned in #1406, this has been automated to be performed based on tag selection. This PR:
draft-release-notes-config.yml
to better reflect labels currently in useinfrastructure
andskip-changelog
, that need to be added to the repoauto-release.yml
enforce-labels.yml
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.