Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSO logs mapping #1403

Closed
wants to merge 23 commits into from
Closed

Support SSO logs mapping #1403

wants to merge 23 commits into from

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Feb 8, 2023

Simple Schema for Observability - SSO - will support the 3 major Observability types:

  • Traces
  • Logs
  • Metrics

SSO will comply with the OTEL schema and continue supporting proprietary index structure
SSO for Logs was also inspired by ECS

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…upport-SSO-Logs-mapping

# Conflicts:
#	schema/logs/README.md
#	schema/logs/communication.mapping
#	schema/logs/http.mapping
#	schema/logs/logs.mapping
…upport-SSO-Logs-mapping

# Conflicts:
#	schema/logs/logs.mapping
Signed-off-by: YANGDB <[email protected]>
@YANG-DB YANG-DB added documentation Improvements or additions to documentation design labels Feb 8, 2023
@YANG-DB YANG-DB added this to the 2.6 milestone Feb 8, 2023
schema/logs/README.md Outdated Show resolved Hide resolved
schema/logs/http.schema Outdated Show resolved Hide resolved
@@ -0,0 +1,223 @@
# Logs Schema Support
Copy link
Member

@vmmusings vmmusings Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any details on versioning support and also examples for adding custom fields.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since other use cases are also trying to use these schemas.(Eg: Security Analytics ) should we keep these templates and schemas in a separate repo which also gives separate visibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on versioning support. We'll need this if the schema changes/upgrades in future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me as well.

Is there a semver like document for schema versioning? Otel has their own definition. It's quite restrictive.

@YANG-DB YANG-DB requested a review from vmmusings February 9, 2023 01:37
Swiddis
Swiddis previously approved these changes Feb 9, 2023
schema/logs/README.md Show resolved Hide resolved
@YANG-DB
Copy link
Member Author

YANG-DB commented Mar 9, 2023

this PR is no longer relevant since introducing the integration as part if the 2.x branch

@YANG-DB YANG-DB closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants