Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics switch #1247

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Conversation

kavithacm
Copy link
Collaborator

Description

  1. Fix metric switch
  2. Auto populate measure field in save panel when a saved object is selected (events)
  3. Remove commented code
  4. Update jest tests

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
@kavithacm kavithacm requested a review from a team as a code owner November 4, 2022 01:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1247 (9623da9) into 2.4 (03b62c2) will increase coverage by 15.68%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1247       +/-   ##
=============================================
+ Coverage     54.58%   70.27%   +15.68%     
  Complexity      292      292               
=============================================
  Files           283       42      -241     
  Lines          9799     2395     -7404     
  Branches       2299      248     -2051     
=============================================
- Hits           5349     1683     -3666     
+ Misses         4279      571     -3708     
+ Partials        171      141       -30     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ability/public/components/common/search/search.tsx
...event_analytics/explorer/save_panel/save_panel.tsx
...lic/components/visualizations/charts/text/text.tsx
...lorer/visualizations/config_panel/config_panel.tsx
...tics/components/common/plots/latency_trend_plt.tsx
...lic/components/common/helpers/add_sample_modal.tsx
...ents/visualizations/charts/metrics/metrics_type.ts
.../components/visualizations/visualization_chart.tsx
...vent_analytics/explorer/sidebar/field_insights.tsx
...blic/components/common/helpers/ppl_docs/groups.tsx
... and 231 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
ps48
ps48 previously approved these changes Nov 4, 2022
rupal-bq
rupal-bq previously approved these changes Nov 4, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
@kavithacm kavithacm dismissed stale reviews from rupal-bq and ps48 via b48d224 November 4, 2022 16:31
@kavithacm kavithacm merged commit 75e74f6 into opensearch-project:2.4 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants